[release/3.0] Update dependencies from dotnet/arcade #6938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…220.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23620.2
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/3.0 #6938 +/- ##
===============================================
- Coverage 68.81% 68.80% -0.01%
===============================================
Files 1240 1240
Lines 249397 249400 +3
Branches 25496 25494 -2
===============================================
- Hits 171614 171610 -4
- Misses 71189 71196 +7
Partials 6594 6594
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Asserting on `_rowCount < Utils.Size(_valueBoundaries)` was catching a case where `_rowCount`'s update was reordered before `_valueBoundaries` This was unnecessary, since this method doesn't need to use `_rowCount`. Instead, make the asserts use only `idx` which will be maintained consistent with the waiter logic in this cache. �Ensure we only ever use `_rowCount` from the caching thread, so write reordering won't matter.
* Don't include the SDK in our helix payload I noticed that the tests included the latest SDK - including the host - in our helix payloads. This is a large amount of unnecessary downloads and it also makes it so we use the latest host on the older frameworks which can fail when the latest host drops support for distros. Since our tests shouldn't need the full CLI, remove this from our helix payloads. We'll instead get just the runtime we need through `AdditionalDotNetPackage` * Place Helix downloaded runtime on the PATH Helix only sets the path when the CLI is included, however we don't need the CLI.
…6923) Precision might cause small differences to round to a different number. Instead compare with a tolerance which is not sensitive to rounding.
|
We may want to "merge" commit on this one to preserve distinct history. I can rebase to combine all the small changes from the previous arcade PR to clean things up. Will do that after I see the build passing for auditing purposes (making sure I got every relevant commit). |
|
Hmm, a couple unique failures here. On Ubuntu: Maybe OOM killer? Though memory went down from previous tests, not sure how much is needed for QA. Coverage build failed Both of these seem unrelated to this change, but curious for your thoughts @michaelgsharp |
|
Seems like those were flaky. This is ready for review @michaelgsharp |
|
@michaelgsharp this is still waiting on your review, please 🙏 |
michaelgsharp
approved these changes
Jan 9, 2024
dotnet-maestro
bot
deleted the
darc-release/3.0-a2cf7474-cd86-4a84-9585-d4f1d0edebcf
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/arcade