Fix inconsistency in DataFrameColumns Clone API implementation #7100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… make base Clone method not virtual and CloneImplementation abstract
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7100 +/- ##
==========================================
- Coverage 68.46% 68.46% -0.01%
==========================================
Files 1263 1263
Lines 254956 254945 -11
Branches 26352 26353 +1
==========================================
- Hits 174552 174542 -10
+ Misses 73698 73697 -1
Partials 6706 6706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michaelgsharp
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Looks good to me. Can you resolve the conflicts @asmirnov82? They might have come from me just merging in your other PR.
# Conflicts: # src/Microsoft.Data.Analysis/DataFrameColumns/ArrowStringDataFrameColumn.cs # src/Microsoft.Data.Analysis/PrimitiveDataFrameColumn.cs
Thanks, Michael. Conflicts are resolved now |
JakeRadMSFT
approved these changes
Apr 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no breaking changes on Public API, mosty only internal implementation is changed
Fixes #7092