-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokenizer's APIs Polishing #7108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tarekgh
commented
Mar 25, 2024
- Eliminate the perplexing specialTokens flag parameter from all APIs.
- Standardize the casing of the Tiktoken name throughout the entire codebase and public interfaces.
- Modify Model.Encode to operate with spans instead of strings. This change maintains consistency across all Model APIs and enables the possibility of incorporating Tokenizer's APIs that also operate with spans in the future.
- Introduce support for precise Last/IndexOf functionality. This enhancement enables the retrieval of indices even within pre-tokenized unit strings passed to the Model. For instance, the Llama model, which does not pre-tokenize, requires this capability to be supported effectively.
stephentoub
reviewed
Mar 25, 2024
stephentoub
reviewed
Mar 25, 2024
stephentoub
reviewed
Mar 25, 2024
stephentoub
reviewed
Mar 25, 2024
stephentoub
reviewed
Mar 25, 2024
stephentoub
reviewed
Mar 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7108 +/- ##
==========================================
- Coverage 68.49% 68.45% -0.04%
==========================================
Files 1262 1262
Lines 254295 254775 +480
Branches 26242 26320 +78
==========================================
+ Hits 174172 174410 +238
- Misses 73432 73663 +231
- Partials 6691 6702 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@stephentoub please let me know if you have more feedback on this PR or we are good to go. Thanks! |
stephentoub
approved these changes
Mar 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.