Merge pull request #408 from peterblazejewicz/fix/396

[fix] provide height hints for carousel controls
dotnet · Jan 23, 2024 · 7312fd7 · 7312fd7
2 parents 9631125 + a4f9d99
commit 7312fd7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/...erInterface/Views/IndicatorViewDemos/IndicatorViewDemos/Views/BasicIndicatorViewPage.xaml b/...erInterface/Views/IndicatorViewDemos/IndicatorViewDemos/Views/BasicIndicatorViewPage.xaml
@@ -8,7 +8,8 @@
         <viewmodels:MonkeysViewModel />
     </ContentPage.BindingContext>
     <StackLayout Margin="10">
-        <CarouselView ItemsSource="{Binding Monkeys}"
+        <CarouselView HeightRequest="400"
+                      ItemsSource="{Binding Monkeys}"
                       IndicatorView="indicatorView">
             <CarouselView.ItemTemplate>
                 <DataTemplate>

diff --git a/...face/Views/IndicatorViewDemos/IndicatorViewDemos/Views/ConfigurableIndicatorViewPage.xaml b/...face/Views/IndicatorViewDemos/IndicatorViewDemos/Views/ConfigurableIndicatorViewPage.xaml
@@ -84,6 +84,7 @@
         </Picker>
         <CarouselView Grid.Row="5"
                       Grid.ColumnSpan="2"
+                      HeightRequest="320"
                       ItemsSource="{Binding Monkeys}"
                       IndicatorView="indicatorView">
             <CarouselView.ItemTemplate>

diff --git a/...terface/Views/IndicatorViewDemos/IndicatorViewDemos/Views/TemplatedIndicatorViewPage.xaml b/...terface/Views/IndicatorViewDemos/IndicatorViewDemos/Views/TemplatedIndicatorViewPage.xaml
@@ -33,7 +33,8 @@
     </ContentPage.Resources>
 
     <StackLayout Margin="10">
-        <CarouselView ItemsSource="{Binding Monkeys}"
+        <CarouselView HeightRequest="400"
+                      ItemsSource="{Binding Monkeys}"
                       IndicatorView="indicatorView">
             <CarouselView.ItemTemplate>
                 <DataTemplate>