Appium Android Fixes #438
Merged
Appium Android Fixes #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
reviewed
Feb 19, 2024
8.0/UITesting/BasicAppiumNunitSample/UITests.Android/AppiumSetup.cs
Outdated
Show resolved
Hide resolved
|
Huh curious! I recall that this worked back then for all scenarios. But indeed the current state on main doesn't and this seems to fix it! |
jfversluis
approved these changes
Feb 20, 2024
|
Note to self: review if the code comments make sense and if we need to add something more to the README of this project for more clarification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell the current Android Appium sample doesn't quite work.
Appium is a bit quirky with Android Apps because in Debug mode you have to enable 'noReset' otherwise appium will delete tthe dlls copied over with fast deployment. I noticed in the current sample we are disabling fast deployment, but I don't think we want to do this as it makes debugs build much slower and is not the normal work flow.