PR feedback

dotnet · Jan 10, 2024 · 83ec31d · 83ec31d
1 parent 8e97a93
commit 83ec31d
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 7 deletions.
diff --git a/src/Controls/src/Core/Handlers/Items/iOS/ItemsViewDelegator.cs b/src/Controls/src/Core/Handlers/Items/iOS/ItemsViewDelegator.cs
@@ -114,10 +114,6 @@ public override void CellDisplayingEnded(UICollectionView collectionView, UIColl
 				// We want to unbind a cell that is no longer present in the items source. Unfortunately
 				// it's too expensive to check directly, so let's check that the current binding context
 				// matches the item at a given position.
-				//
-				//var itemIndex = ViewController?.ItemsSource.GetIndexForItem(bindingContext);
-				//if (itemIndex.Item == -1)
-				// 	templatedCell.Unbind();
 
 				var itemsSource = ViewController?.ItemsSource;
 				if (itemsSource is null ||

diff --git a/src/Controls/src/Core/Handlers/Items/iOS/TemplatedCell.cs b/src/Controls/src/Core/Handlers/Items/iOS/TemplatedCell.cs
@@ -58,7 +58,7 @@ protected void ClearConstraints()
 			ConstrainedDimension = default;
 		}
 
-		public void Unbind()
+		internal void Unbind()
 		{
 			if (PlatformHandler?.VirtualView is View view)
 			{

diff --git a/src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt b/src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt
@@ -88,7 +88,6 @@ virtual Microsoft.Maui.Controls.DragStartingEventArgs.GetPosition(Microsoft.Maui
 virtual Microsoft.Maui.Controls.DropEventArgs.GetPosition(Microsoft.Maui.Controls.Element? relativeTo) -> Microsoft.Maui.Graphics.Point?
 *REMOVED*override Microsoft.Maui.Controls.RefreshView.MeasureOverride(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
 Microsoft.Maui.Controls.Border.~Border() -> void
-Microsoft.Maui.Controls.Handlers.Items.TemplatedCell.Unbind() -> void
 Microsoft.Maui.Controls.IWindowCreator
 Microsoft.Maui.Controls.IWindowCreator.CreateWindow(Microsoft.Maui.Controls.Application! app, Microsoft.Maui.IActivationState? activationState) -> Microsoft.Maui.Controls.Window!
 Microsoft.Maui.Controls.Handlers.Compatibility.PhoneFlyoutPageRenderer.FlyoutOverlapsDetailsInPopoverMode.get -> bool

diff --git a/src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt b/src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
@@ -87,7 +87,6 @@ virtual Microsoft.Maui.Controls.DragStartingEventArgs.GetPosition(Microsoft.Maui
 virtual Microsoft.Maui.Controls.DropEventArgs.GetPosition(Microsoft.Maui.Controls.Element? relativeTo) -> Microsoft.Maui.Graphics.Point?
 *REMOVED*override Microsoft.Maui.Controls.RefreshView.MeasureOverride(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
 Microsoft.Maui.Controls.Border.~Border() -> void
-Microsoft.Maui.Controls.Handlers.Items.TemplatedCell.Unbind() -> void
 Microsoft.Maui.Controls.IWindowCreator
 Microsoft.Maui.Controls.IWindowCreator.CreateWindow(Microsoft.Maui.Controls.Application! app, Microsoft.Maui.IActivationState? activationState) -> Microsoft.Maui.Controls.Window!
 Microsoft.Maui.Controls.Handlers.Compatibility.PhoneFlyoutPageRenderer.FlyoutOverlapsDetailsInPopoverMode.get -> bool