Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework LogicalChildren on Element to better represent visual vs logical children #11528

Closed
PureWeen opened this issue Nov 21, 2022 · 2 comments
Closed
Labels
area-architecture Issues with code structure, SDK structure, implementation details proposal/open
Milestone

Comments

@PureWeen
Copy link
Member

PureWeen commented Nov 21, 2022

Description

Copied From xamarin/Xamarin.Forms#6106

This PR
#9221

Started the idea at the shell level for generalizing the AddLogical / RemoveLogical calls. Ideally, we'd move this up to Element or tie it naturally into parenting. For example, if I set someone as my parent then I automatically become a logical child. It's currently very difficult for someone to opt into our LogicalChidlren flow which also has negative effects on LVT and forces users to implement IVT which only makes it so a control will take advantage of the Live Visual Tree but then won't take part in BC and Style propagation.

The other advantage here is that it will allow control developers an easy hook point to implement the same behavior. They can attach logical elements to pages or elements and our Framework will auto propagate css, binding, etc..

@PureWeen PureWeen added proposal/open area-architecture Issues with code structure, SDK structure, implementation details labels Nov 21, 2022
@PureWeen PureWeen added this to the Backlog milestone Nov 21, 2022
@ghost
Copy link

ghost commented Nov 21, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@PureWeen
Copy link
Member Author

#16046

@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-architecture Issues with code structure, SDK structure, implementation details proposal/open
Projects
None yet
Development

No branches or pull requests

1 participant