Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Rework LogicalChildren on Element to better represent visual vs logical children #6106

Closed
PureWeen opened this issue May 6, 2019 · 1 comment
Labels
4.1.0 regression on 4.1.0 e/4 🕓 4 inactive Issue is older than 6 months and needs to be retested t/bug 🐛 t/enhancement ➕
Projects

Comments

@PureWeen
Copy link
Contributor

PureWeen commented May 6, 2019

Description

Titleview was the first version of this but Shell introduced a lot of cases where you will attach a View to an element and it should inherit a lot of features of being a child to that element (css, binding, etc..) but the child should not be drawn by the element

This PR
#6082

Starts the idea but only gets it about 80 percent there

ShellSection also uses this concept

internal override ReadOnlyCollection<Element> LogicalChildrenInternal => _logicalChildrenReadOnly ?? (_logicalChildrenReadOnly = new ReadOnlyCollection<Element>(_logicalChildren));

By differentiating between Items (visual children) and LogicalChildren (things that are just part of a section)

But this idea needs to be better standardized across the framework.

The other advantage here is that it will allow control developers an easy hook point to implement the same behavior. They can attach logical elements to pages or elements and our Framework will auto propagate css, binding, etc.. to those without actually trying to render them

@PureWeen PureWeen added this to the 4.1.0 milestone May 6, 2019
@PureWeen PureWeen self-assigned this May 6, 2019
@PureWeen PureWeen added this to To do in v4.1.0 via automation May 6, 2019
@pauldipietro pauldipietro added this to New in Triage May 6, 2019
@PureWeen PureWeen changed the title Rework LogicalChildren on Element to better represent visual vs logical chidlren Rework LogicalChildren on Element to better represent visual vs logical children May 6, 2019
@PureWeen PureWeen added the e/4 🕓 4 label May 6, 2019
@PureWeen PureWeen removed this from New in Triage May 6, 2019
@samhouts samhouts added the 4.1.0 regression on 4.1.0 label Sep 12, 2019
@samhouts samhouts removed this from the 4.1.0 milestone Sep 12, 2019
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Nov 3, 2019
@samhouts samhouts removed help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Feb 4, 2020
@PureWeen PureWeen removed their assignment Jul 9, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added this to To do in vNext+1 (5.0.0) Aug 14, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
@jfversluis
Copy link
Member

I think this has seen some effort in .NET MAUI, let's focus on this there!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4.1.0 regression on 4.1.0 e/4 🕓 4 inactive Issue is older than 6 months and needs to be retested t/bug 🐛 t/enhancement ➕
Projects
No open projects
v4.1.0
  
To do
Development

No branches or pull requests

3 participants