Bitcode is deprecated when publishing app to appstore MAUI in 7.0.200-preview.22628.1 #12863

KSemenenko · 2023-01-23T20:40:01Z

Description

I installed the latest version of VS code for Mac (7.0.200-preview.22628.1 with MAUI workload) and found out that this issue is still there.
#10989

Steps to Reproduce

Use a framework containing bitcode

Link to public reproduction project repository

no

Version with bug

Unknown/Other (please specify)

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

IOS

Did you find any workaround?

 <PropertyGroup>
    <!-- Properties used to strip bitcode from frameworks when using Visual Studio for Mac -->
    <_StripBitcodeFromFrameworksMasterAfterTargets Condition="'$(OS)'=='Unix'">_ExpandNativeReferences</_StripBitcodeFromFrameworksMasterAfterTargets>
    <_StripBitcodeFromFrameworksMasterDependsOnTargets Condition="'$(OS)'=='Unix'">_StripBitcodeFromFrameworksOnMac</_StripBitcodeFromFrameworksMasterDependsOnTargets>

    <!-- Properties used to strip bitcode from frameworks when using Visual Studio for Windows -->
    <_StripBitcodeFromFrameworksMasterAfterTargets Condition="'$(OS)'!='Unix'">_ComputeFrameworkFilesToPublish</_StripBitcodeFromFrameworksMasterAfterTargets>
    <_StripBitcodeFromFrameworksMasterDependsOnTargets Condition="'$(OS)'!='Unix'">_StripBitcodeFromFrameworksOnWindows</_StripBitcodeFromFrameworksMasterDependsOnTargets>
  </PropertyGroup>
  
  <Target Name="_StripBitcodeFromFrameworksMasterTarget" 
          Condition="'$(_StripBitcodeFromFrameworksMasterDependsOnTargets)'!='' AND @(_FrameworkNativeReference->Count()) != 0" 
          AfterTargets="$(_StripBitcodeFromFrameworksMasterAfterTargets)" 
          DependsOnTargets="$(_StripBitcodeFromFrameworksMasterDependsOnTargets)" />

  <Target Name="_StripBitcodeFromFrameworksOnMac"
          Condition="('$(OutputType)'!='Library' OR '$(IsAppExtension)'=='True') AND '$(_SdkIsSimulator)'=='False'">
    
    <!-- Find the bitcode_strip command -->
    <Exec Command="xcrun -find bitcode_strip" ConsoleToMSBuild="true">
      <Output TaskParameter="ConsoleOutput" PropertyName="_BitcodeStripCommand" />
    </Exec>

    <!-- Strip the bitcode from frameworks -->
    <Exec Command="$(_BitcodeStripCommand) %(_FrameworkNativeReference.Identity) -r -o %(_FrameworkNativeReference.Identity)" />
  </Target>

  <Target Name="_StripBitcodeFromFrameworksOnWindows"
          Condition="('$(OutputType)'!='Library' OR '$(IsAppExtension)'=='True') AND '$(_SdkIsSimulator)'=='False' AND '$(IsMacEnabled)'=='true'">

    <!-- Strip the bitcode from frameworks -->
    <Exec SessionId="$(BuildSessionId)"
          Command="&quot;%24(xcrun -find bitcode_strip)&quot; %(_FrameworkNativeReference.Identity) -r -o %(_FrameworkNativeReference.Identity)" />

    <CopyFileFromBuildServer 
      SessionId="$(BuildSessionId)" 
      File="%(_FrameworkNativeReference.Identity)" 
      TargetFile="%(_FrameworkNativeReference.Identity)" />    
  </Target>

This code helped me. the solution works.
Maybe it should be added by default?

Relevant log output

No response

PureWeen · 2023-01-25T19:29:36Z

@SotoiGhost thoughts?

SotoiGhost · 2023-01-25T21:22:17Z

Hi @KSemenenko! 👋🏼 Thank you for your time in reporting this issue.

I think this is a question for the iOS team. The workaround seems harmless, but not sure if this could cause any harm later as this is directly modifying the framework saved on the disk.

@dalexsoto, @rolfbjarne, thoughts on this?

P.S: Regardless of whether this is added, it is best to report the affected framework to its owner so they can fix this from the root.

KSemenenko · 2023-01-26T00:01:43Z

I'm currently doing native binding for agora, they have xcframework.
This is their official sdk, and it seems to work for swift or objective c.

I have this issue when I send the binary to TestFlight.

Also, the experience with bindings in general is not very smooth. It turned out that sln with the bindings library can't be next to maui project. It should be a separate project.

I'm still working on it, but if you need any feedback, I'll be happy to help =)

SotoiGhost · 2023-01-26T00:13:02Z

@KSemenenko you can verify if a framework has bitcode or has the bitcode marker flag enabled by running the following command:

# Replace the path
otool -l path/to/your/Foo.xcframework/ios-arm64/Foo.framework/Foo | grep __LLVM -1

The command should not throw anything if there's no bitcode, otherwise will throw you something like this:

  cmdsize 152
  segname __LLVM
   vmaddr 0x000000000006c000
--
  sectname __bundle
   segname __LLVM
      addr 0x000000000006c000

Hope this helps you!

KSemenenko · 2023-01-26T06:58:42Z

Thanks for your advice, I think now that my sdk is swift.
https://learn.microsoft.com/en-us/xamarin/ios/platform/binding-swift/walkthrough

Will try this one

KSemenenko · 2023-01-26T08:21:06Z

one more questions, https://swiftpackageindex.com/AgoraIO/AgoraRtcEngine_iOS
so this is swift, but if it xcframework I have to anyway create one more swift librarty or I can just use sdk, because thay have h files

rolfbjarne · 2023-01-26T09:08:30Z

Also, the experience with bindings in general is not very smooth. It turned out that sln with the bindings library can't be next to maui project. It should be a separate project.

Yes, we know it's not very smooth, we have known issues we're working on in this area.

I think this is a question for the iOS team. The workaround seems harmless, but not sure if this could cause any harm later as this is directly modifying the framework saved on the disk.

Yes, the workaround seems harmless, but I'm hesitant to add code on our side for this, because:

The app developer can work around it themselves.
The real fix is for the vendor to fix their SDK to not contain bitcode (since Apple completely deprecated bitcode, at the very least it's useless to ship it).
It may seem harmless, but there's always a risk.

KSemenenko · 2023-01-26T10:51:58Z

@rolfbjarne thanks for answers!

Well, in fact, for me it is the documentation that is the most difficult. I do not understand the clear steps to be taken. I'm C# developer and have no idea aboout swift and xcode.

So far I have realized that I have to make another library which will be a wrapper for the sdk (and this makes a lot of sense)
But on the other side of the SDK is the same exact library .framework
And according to the documentation, I then have to add to the iOS project a link to the original sdk and a link to my new library-binding-wrapper. But then why do I need an wrapper?

But I'm optimistic and determined to do it =)

ghost · 2023-01-27T15:20:07Z

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

Syed-RI · 2023-04-13T11:25:56Z

I think this should be a build task enabled via a flag

vplife1 · 2023-10-19T19:47:43Z

@SotoiGhost I have tried above code lines but show the following error

The command "/Users/apple/Downloads/Xcode 2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/bitcode_strip /Users/apple/.nuget/packages/harfbuzzsharp.nativeassets.ios/2.8.2.3/runtimes/ios/native/libHarfBuzzSharp.framework/libHarfBuzzSharp -r -o /Users/apple/.nuget/packages/harfbuzzsharp.nativeassets.ios/2.8.2.3/runtimes/ios/native/libHarfBuzzSharp.framework/libHarfBuzzSharp" exited with code 127. (MSB3073)

Please provide me a appropriate solution

vplife1 · 2023-10-19T19:48:06Z

I have used the above code snippet but it shows an error follows how to resolve it
I have tried above code lines but show the following error

The command "/Users/apple/Downloads/Xcode 2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/bitcode_strip /Users/apple/.nuget/packages/harfbuzzsharp.nativeassets.ios/2.8.2.3/runtimes/ios/native/libHarfBuzzSharp.framework/libHarfBuzzSharp -r -o /Users/apple/.nuget/packages/harfbuzzsharp.nativeassets.ios/2.8.2.3/runtimes/ios/native/libHarfBuzzSharp.framework/libHarfBuzzSharp" exited with code 127. (MSB3073)

Please provide me a appropriate solution

rolfbjarne · 2023-10-20T06:20:04Z

@vplife1 please attach a binlog (https://aka.ms/binlog) that shows the error.

vplife1 · 2023-10-20T06:26:55Z

@rolfbjarne and @Eilon and @SotoiGhost I am facing issue when try to add my app on app store it throws the following iisues
We identified one or more issues with a recent delivery for your app, "Calmanac App" 1.0 (3). Please correct the following issues, then upload again.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/FBLPromises.framework/FBLPromises' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/FirebaseCore.framework/FirebaseCore' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/FirebaseCoreDiagnostics.framework/FirebaseCoreDiagnostics' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/FirebaseInstallations.framework/FirebaseInstallations' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/FirebaseMessaging.framework/FirebaseMessaging' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/GTMSessionFetcher.framework/GTMSessionFetcher' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/GoogleAPIClientForREST.framework/GoogleAPIClientForREST' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/GoogleDataTransport.framework/GoogleDataTransport' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/GoogleToolboxForMac.framework/GoogleToolboxForMac' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/GoogleUtilities.framework/GoogleUtilities' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/Protobuf.framework/Protobuf' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/leveldb.framework/leveldb' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'CalmanacMobileAPP.app/Frameworks/nanopb.framework/nanopb' contains bitcode.

Please suggest me a correct way how to resolve this issue , I am not able to add my app on app store test flight

maonaoda · 2023-10-23T10:07:39Z

whats wrong, i cant build ios device any more.

1>C:\Program Files\dotnet\packs\Microsoft.iOS.Sdk\16.4.8968-net8-rc2\targets\Xamarin.Shared.Sdk.targets(744,3): warning MT7091: 框架 C:/Users/xyz/.nuget/packages/xamarin.firebase.ios.core/8.10.0.3/lib/net6.0-ios15.4/Firebase.Core.resources/GoogleUtilitiesComponents.xcframework/ios-arm64/GoogleUtilitiesComponents.framework 是静态库的框架，不会复制到应用。
1>"$(xcrun -find bitcode_strip)"  -r -o
1>C:\Users\xyz\.nuget\packages\xamarin.firebase.ios.core\8.10.0.3\buildTransitive\Xamarin.Firebase.iOS.Core.targets(216,5): error : /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/bitcode_strip: missing argument(s) to: -o option
1>Usage: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/bitcode_strip input [-r | -m | -l] [-keep_cs] -o output
1>C:\Users\xyz\.nuget\packages\xamarin.firebase.ios.core\8.10.0.3\buildTransitive\Xamarin.Firebase.iOS.Core.targets(216,5): error MSB3073: 命令“"$(xcrun -find bitcode_strip)"  -r -o ”exit，code is 1。

vplife1 · 2023-10-23T10:54:28Z

@rolfbjarne please check binlogs
binlogs.zip

Still, I am facing the same issue reply to me ASAP. It's very needful

vplife1 · 2023-10-23T11:01:57Z

@maonaoda Are you facing the same issue
We identified one or more issues with a recent delivery for your app, "Calmanac App" 1.0 (3). Please correct the following issues, then upload again.