Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not Planned] Work required to better enable adding platforms to MAUI #12947

Open
PureWeen opened this issue Jan 26, 2023 · 3 comments
Open

[Not Planned] Work required to better enable adding platforms to MAUI #12947

PureWeen opened this issue Jan 26, 2023 · 3 comments
Labels
area-setup Installation, setup, requirements, maui-check, workloads, platform support proposal/not-planned
Milestone

Comments

@PureWeen
Copy link
Member

PureWeen commented Jan 26, 2023

Description

These items are based on a quick spike adding WPF here
This is in no way an indication of future plans. This is just PureWeen testing something out and seeing areas where we could easily expose some more public APIs.

  • Make an interface for AlertManager and make it public
  • OpenWindowRequest only accepts IPersistedState and a specific args for WinUI which makes passing in startup args awkward.
  • LifeCycle commands on pages need to be made public or interface driven (sendnavigated, sendappearing, etc...)
  • ModalNavigationManager needs a public interface
  • AlertManager needs a public interface
  • GestureManager needs a public interface
  • WinUI targets need to be shifted so they are conditional on WinUI. Currently if the OS is windows we assume WinUI which makes creating a project with <UseWPF> not possible

First impression

You can get pretty far with the current implementation.

I was able to get some features here working https://github.com/PureWeen/maui/tree/wpf_separate_project/src/Controls/samples/Controls.Sample.WPF.

  • Handlers
    • This is really the meat of it. If you just filled in all the basic control handlers (not even page level) this would cover about 90 percent of a MAUI app.
  • Fixing WinUI targets is the most important thing to fix in order to be able to do UseMauiCore/UseMaui alongside UseWPF (this is only applicable to windows based TFMS)
@PureWeen PureWeen added this to the Backlog milestone Jan 26, 2023
@ghost
Copy link

ghost commented Jan 26, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@PureWeen PureWeen changed the title Work required to better enable adding platforms to MAUI [Not Planned] Work required to better enable adding platforms to MAUI Jan 26, 2023
@rmarinho
Copy link
Member

rmarinho commented Feb 9, 2023

Did we get an idea what we need to change on the targets to make condition based on WinUI and not windows?!

@PureWeen
Copy link
Member Author

PureWeen commented Feb 9, 2023

Did we get an idea what we need to change on the targets to make condition based on WinUI and not windows?!

Yea I basically have those changes here
main...PureWeen:maui:wpf_separate_project

For my spike I'm keying off of UseWpf but it'd probably be better to key off of something inside WinUI instead.

Replace this conditional here
main...PureWeen:maui:wpf_separate_project#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16eR23

With something a bit more elegant

@Eilon Eilon added the area-setup Installation, setup, requirements, maui-check, workloads, platform support label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-setup Installation, setup, requirements, maui-check, workloads, platform support proposal/not-planned
Projects
None yet
Development

No branches or pull requests

3 participants