Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] preview 5 project template includes unoptimized assemblies #1388

Closed
bruno-garcia opened this issue Jun 19, 2021 · 1 comment
Closed
Assignees
Labels
s/not on roadmap This will not be worked on

Comments

@bruno-garcia
Copy link
Member

Description

A .NET 6 preview 5 MAUI project includes dependencies that were compiled without optimizations.

Steps to Reproduce

  1. Install .NET 6 preview 5
  2. dotnet new maui
  3. Add analyzer NuGet Package UnoptimizedAssemblyDetector

Expected Behavior

Builds without warnings

Actual Behavior

/Users/bruno/.nuget/packages/unoptimizedassemblydetector/0.1.1/build/UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'Esp.dll' at /Users/bruno/.nuget/packages/reloadify3000/1.0.6/lib/netstandard2.0/Esp.dll [/Users/bruno/git/sentry-dotnet/samples/Sentry.Samples.Maui/Sentry.Samples.Maui.csproj]
/Users/bruno/.nuget/packages/unoptimizedassemblydetector/0.1.1/build/UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'Esp.Resources.dll' at /Users/bruno/.nuget/packages/reloadify3000/1.0.6/lib/netstandard2.0/Esp.Resources.dll [/Users/bruno/git/sentry-dotnet/samples/Sentry.Samples.Maui/Sentry.Samples.Maui.csproj]
/Users/bruno/.nuget/packages/unoptimizedassemblydetector/0.1.1/build/UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'Reloadify3000.Core.dll' at /Users/bruno/.nuget/packages/reloadify3000/1.0.6/lib/netstandard2.0/Reloadify3000.Core.dll [/Users/bruno/git/sentry-dotnet/samples/Sentry.Samples.Maui/Sentry.Samples.Maui.csproj]
/Users/bruno/.nuget/packages/unoptimizedassemblydetector/0.1.1/build/UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'Reloadify3000.dll' at /Users/bruno/.nuget/packages/reloadify3000/1.0.6/lib/netstandard2.0/Reloadify3000.dll [/Users/bruno/git/sentry-dotnet/samples/Sentry.Samples.Maui/Sentry.Samples.Maui.csproj]
/Users/bruno/.nuget/packages/unoptimizedassemblydetector/0.1.1/build/UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'Esp.dll' at /Users/bruno/.nuget/packages/reloadify3000/1.0.6/lib/netstandard2.0/Esp.dll [/Users/bruno/git/sentry-dotnet/samples/Sentry.Samples.Maui/Sentry.Samples.Maui.csproj]
/Users/bruno/.nuget/packages/unoptimizedassemblydetector/0.1.1/build/UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'Esp.Resources.dll' at /Users/bruno/.nuget/packages/reloadify3000/1.0.6/lib/netstandard2.0/Esp.Resources.dll [/Users/bruno/git/sentry-dotnet/samples/Sentry.Samples.Maui/Sentry.Samples.Maui.csproj]
/Users/bruno/.nuget/packages/unoptimizedassemblydetector/0.1.1/build/UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'Reloadify3000.Core.dll' at /Users/bruno/.nuget/packages/reloadify3000/1.0.6/lib/netstandard2.0/Reloadify3000.Core.dll [/Users/bruno/git/sentry-dotnet/samples/Sentry.Samples.Maui/Sentry.Samples.Maui.csproj]
/Users/bruno/.nuget/packages/unoptimizedassemblydetector/0.1.1/build/UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'Reloadify3000.dll' at /Users/bruno/.nuget/packages/reloadify3000/1.0.6/lib/netstandard2.0/Reloadify3000.dll [/Users/bruno/git/sentry-dotnet/samples/Sentry.Samples.Maui/Sentry.Samples.Maui.csproj]

Basic Information

All assemblies seem to come from a single NuGet package. Reloadify3000 version 1.0.6

@Redth Redth added this to the 6.0.100-preview.7 milestone Jul 12, 2021
@Redth Redth added the s/not on roadmap This will not be worked on label Jul 12, 2021
@Clancey
Copy link
Contributor

Clancey commented Jul 12, 2021

This package is only used for debug builds, And it will be removed as a dependency when Dotnet hot reload is ready!

@Redth Redth closed this as completed Jul 12, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
s/not on roadmap This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants