Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression/8.0.0-preview.5.8529] Provide API to set ImageSource to the ImageSourcePartLoader #16367

Closed
APopatanasov opened this issue Jul 26, 2023 · 1 comment · Fixed by #16633
Assignees
Labels
area-controls-image Image control fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 i/regression This issue described a confirmed regression on a currently supported version p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with partner Issue or Request from a partner team t/bug Something isn't working
Milestone

Comments

@APopatanasov
Copy link

APopatanasov commented Jul 26, 2023

Description

In net7 we are using the ImageSourcePartLoader class to load native images for several properties of type ImageSource. However, after this change this is no longer possible. Now in net8 the source is tightly coupled with the virtual MAUI view.

Because of that you are no longer able to have two (or more) properties of type ImageSource in the MAUI virtual view. We are looking for a way to load properties of type ImageSource without being dependent on the virtual MAUI control.

Public API Changes

You can provide a way to set the ImageSource of the ImageSourcePartLoaded through the constructor for example or with a property.

If this is not an option can you at least make the following extension method public so we can try loading the native images without the usage of ImageSourcePartLoaded:
https://github.com/dotnet/maui/blob/release/8.0.1xx-preview6/src/Core/src/Platform/iOS/ImageSourcePartExtensions.cs
https://github.com/dotnet/maui/blob/release/8.0.1xx-preview6/src/Core/src/Platform/Android/ImageSourcePartExtensions.cs
https://github.com/dotnet/maui/blob/release/8.0.1xx-preview6/src/Core/src/Platform/Windows/ImageSourcePartExtensions.cs

The method is already public for Tizen, so it will be nice to have it for Android, iOS and WinUI as well.

Intended Use-Case

In my custom control I have more than one property of type ImageSource. By implementing the IImageSourcePart interface I can return only a single property that will be loaded by the ImageSourcePartLoaded class.

@jsuarezruiz jsuarezruiz added partner Issue or Request from a partner team area-controls-image Image control labels Jul 26, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 26, 2023
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Jul 28, 2023
@ghost
Copy link

ghost commented Jul 28, 2023

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

@PureWeen PureWeen added the i/regression This issue described a confirmed regression on a currently supported version label Jul 29, 2023
@PureWeen PureWeen modified the milestones: Backlog, .NET 8 GA Aug 1, 2023
@mikeparker104 mikeparker104 added the partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with label Aug 1, 2023
@samhouts samhouts added t/bug Something isn't working and removed proposal/open labels Aug 1, 2023
@samhouts samhouts changed the title Provide API to set ImageSource to the ImageSourcePartLoader [regression/8.0.0-preview.5.8529] Provide API to set ImageSource to the ImageSourcePartLoader Aug 1, 2023
@samhouts samhouts added the p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint label Aug 2, 2023
@jsuarezruiz jsuarezruiz self-assigned this Aug 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Jan 31, 2024
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-image Image control fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 i/regression This issue described a confirmed regression on a currently supported version p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with partner Issue or Request from a partner team t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants