Make ImageSourcePartExtensions public #16633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
commented
Aug 9, 2023
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| namespace Microsoft.Maui.Platform | |||
| { | |||
| internal static class ImageSourcePartExtensions | |||
| public static class ImageSourcePartExtensions | |||
There was a problem hiding this comment.
This change aligns all platforms (in Tizen this extension method was already public in .NET 7) and allows a way to load images without dependencies on the VirtualView.
jsuarezruiz
commented
Aug 9, 2023
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| namespace Microsoft.Maui.Platform | |||
| { | |||
| internal static class ImageSourcePartExtensions | |||
| public static class ImageSourcePartExtensions | |||
There was a problem hiding this comment.
Feedback on making these methods public for .NET 8? We must also add a property to allow set the ImageSource of the ImageSourcePartLoaded?
jsuarezruiz
added
the
i/regression
mattleibow
approved these changes
Aug 16, 2023
rmarinho
pushed a commit
that referenced
this pull request
Aug 19, 2023
mattleibow
added a commit
that referenced
this pull request
Aug 21, 2023
This reverts commit 8b5c996.
PureWeen
pushed a commit
that referenced
this pull request
Aug 21, 2023
Eilon
added
area-controls-image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Make
ImageSourcePartExtensionspublic.Fixes