Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button ImageSource not Scaling as expected. #18242

Closed
mla03 opened this issue Oct 23, 2023 · 3 comments · Fixed by #19834, #20949 or #21759
Closed

Button ImageSource not Scaling as expected. #18242

mla03 opened this issue Oct 23, 2023 · 3 comments · Fixed by #19834, #20949 or #21759
Assignees
Labels
area-controls-button Button, ImageButton fixed-in-8.0.10 fixed-in-8.0.14 fixed-in-8.0.20 fixed-in-8.0.40 fixed-in-9.0.0-preview.3.10457 p/1 Work that is critical for the release, but we could probably ship without partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with platform/android 🤖 platform/iOS 🍎 platform/windows 🪟 potential-regression This issue described a possible regression on a currently supported version., verification pending s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working

Comments

@mla03
Copy link

mla03 commented Oct 23, 2023

Description

Using a Button and adding a ImageSource, svg, the image is not scaled as expected.
According to Documentation: While Button defines an ImageSource property, that allows you to display a image on the Button, this property is intended to be used when displaying a small icon next to the Button text.

On the screenshots below the first component is a Button with ImageSource, and the Second is a HorizontalStackLayout with ImageButton and Label, set up with same HeightRequest.

iOS:
image

Android:
image

And since I am using it in a popup dialog from CommunityToolkit i'm unable to use method 2, since GestureRecognizers are not working.

xaml to reproduce:
image

Steps to Reproduce

  1. Remove content of VerticalStackLayout in Maui sample app.
  2. Add screenshot of xaml as content. (could not get 'code' to work)

Link to public reproduction project repository

No response

Version with bug

8.0.0-rc.2.9373

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response

@mla03 mla03 added the t/bug Something isn't working label Oct 23, 2023
@jsuarezruiz jsuarezruiz added the area-controls-button Button, ImageButton label Oct 23, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Oct 23, 2023
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Oct 23, 2023
@ghost
Copy link

ghost commented Oct 23, 2023

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Oct 25, 2023
@XamlTest
Copy link
Collaborator

Verified this on Visual Studio Enterprise 17.8.0 Preview 5.0(8.0.0-rc.2.9373). Repro on Android 14.0-API34 and iOS 16.4, also repro on Windows 11 with below Project:
18242.zip
Windows(.NET 8):
image

In addition, the issue does not repro on Windows(7.0.96), but repro on Android 14.0-API34 and iOS 16.4 platform.
Windows(.NET 7):
image

@lothrop
Copy link

lothrop commented Nov 21, 2023

The Windows behavior is blocking our upgrade to .NET 8.

@mikeparker104 mikeparker104 added partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with platform/windows 🪟 labels Dec 15, 2023
@samhouts samhouts added p/1 Work that is critical for the release, but we could probably ship without potential-regression This issue described a possible regression on a currently supported version., verification pending labels Dec 19, 2023
@Redth Redth modified the milestones: Backlog, .NET 8 + Servicing Jan 10, 2024
@jsuarezruiz jsuarezruiz self-assigned this Jan 11, 2024
@PureWeen PureWeen reopened this Mar 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-button Button, ImageButton fixed-in-8.0.10 fixed-in-8.0.14 fixed-in-8.0.20 fixed-in-8.0.40 fixed-in-9.0.0-preview.3.10457 p/1 Work that is critical for the release, but we could probably ship without partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with platform/android 🤖 platform/iOS 🍎 platform/windows 🪟 potential-regression This issue described a possible regression on a currently supported version., verification pending s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
Status: Done
9 participants