Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgot to remove PropertyChanged in TabbedPageManager of Element`s InternalChildren, which caused NRE #18457

Closed
maonaoda opened this issue Nov 1, 2023 · 0 comments · Fixed by #18458
Closed

Forgot to remove PropertyChanged in TabbedPageManager of Element`s InternalChildren, which caused NRE #18457

maonaoda opened this issue Nov 1, 2023 · 0 comments · Fixed by #18458
Labels
area/TabbedPage TabbedPage fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! fixed-in-8.0.10 fixed-in-8.0.14 migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/android 🤖 t/bug Something isn't working
Milestone
.NET 8 SR1

Comments

@maonaoda
Copy link
Contributor

maonaoda commented Nov 1, 2023

Description

Bug is Here :

maui/src/Controls/src/Core/Platform/Android/TabbedPageManager.cs

Line 119 in c745e23

((IPageController)Element).InternalChildren.CollectionChanged -= OnChildrenCollectionChanged;

Element will be null and cause NRE

image
image

Steps to Reproduce

  1. Return the app to the background from the TabbedPage
  2. Reopen the App
  3. Respond to page changes

Link to public reproduction project repository

No response

Version with bug

8.0.0-rc.2.9373

Is this a regression from previous behavior?

Yes, this used to work in Xamarin.Forms

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response
@maonaoda maonaoda added the t/bug Something isn't working label Nov 1, 2023
@maonaoda maonaoda mentioned this issue Nov 1, 2023
Merged
@PureWeen PureWeen added this to the .NET 8 SR2 milestone Nov 8, 2023
@PureWeen PureWeen mentioned this issue Nov 22, 2023
Closed
@PureWeen PureWeen modified the milestones: .NET 8 SR2, .NET 8 SR3 Nov 22, 2023
@PureWeen PureWeen modified the milestones: .NET 8 SR3, .NET 8 SR1 Nov 30, 2023
@samhouts samhouts added the migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert label Dec 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
@samhouts samhouts added the fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! label Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/TabbedPage TabbedPage fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! fixed-in-8.0.10 fixed-in-8.0.14 migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/android 🤖 t/bug Something isn't working
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 8 SR1
3 participants
@PureWeen @samhouts @maonaoda