Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe from CollectionChanged when the Element is changed. #18960

Closed
wants to merge 1 commit into from

Conversation

PureWeen
Copy link
Member

Description of Change

Unsubscribe from CollectionChanged when the Element is changed.

Recreating this PR from here #18458

I tried updating the original PR but it seems like the changes didn't take.

Issues Fixed

Fixes #18457

@PureWeen PureWeen requested a review from a team as a code owner November 22, 2023 17:25
@PureWeen PureWeen changed the title - add test Unsubscribe from CollectionChanged when the Element is changed. Nov 22, 2023
@PureWeen PureWeen closed this Nov 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forgot to remove PropertyChanged in TabbedPageManager of Element`s InternalChildren, which caused NRE
1 participant