Location constructor silently cuts off latitude and longitude values

[janusw]

Description

When constructing a Microsoft.Maui.Devices.Sensors.Location from a latitude/longitude pair, the constructor silently seems to cut off the values, if they are outside of the expected range:

• latitude values that are larger than 90 degrees are cut down to 90, values smaller than -90 are cut to -90
• longitude values that are larger than 180 degrees are cut down to 180, values smaller than -180 are cut to -180

This did not occur with Xamarin.Essentials, and IMHO it is not a good way to deal with this situation. Better options would be:

1. Throw an ArgumentOutOfRangeException or ...
2. ... use a modulus / remainder operation to project the values into the allowed range. In particular this would make sense for the longitude (but not so much for the latitude, I guess).

In any case, the behavior and the allowed values should be documented.

Steps to Reproduce

Execute the following test case:

using System.Diagnostics;
using Microsoft.Maui.Devices.Sensors;

var loc = new Location(0, 200);
Debug.WriteLine($"{loc.Latitude}, {loc.Longitude}");

Expected outcome: 0, -160 (or throw an ArgumentOutOfRangeException)

Actual outcome: 0, 180

Link to public reproduction project repository

No response

Version with bug

8.0.3

Is this a regression from previous behavior?

Yes, this used to work in Xamarin.Forms

Last version that worked well

Unknown/Other

Affected platforms

macOS

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response

[janusw]

This is the relevant code:

maui/src/Essentials/src/Types/Location.shared.cs

Lines 54 to 59 in 9b99433

	public Location(double latitude, double longitude)
	{
	Latitude = Math.Min(Math.Max(latitude, -90.0), 90.0);
	Longitude = Math.Min(Math.Max(longitude, -180.0), 180.0);
	Timestamp = DateTimeOffset.UtcNow;
	}

In Xamarin it looked like this (no limiting/cutting of values there):

https://github.com/xamarin/Essentials/blob/6ec2124ec4354a0631de2c233a3d29123015f6df/Xamarin.Essentials/Types/Location.shared.cs#L28-L33

[janusw]

Additional inconsistency: The other Location constructors behave differently and do not cut the input values. All of them should behave in the same way (by calling each other if non-trivial checks or modifications are involved).

maui/src/Essentials/src/Types/Location.shared.cs

Lines 67 to 72 in 9b99433

	public Location(double latitude, double longitude, DateTimeOffset timestamp)
	{
	Latitude = latitude;
	Longitude = longitude;
	Timestamp = timestamp;
	}

maui/src/Essentials/src/Types/Location.shared.cs

Lines 80 to 86 in 9b99433

	public Location(double latitude, double longitude, double altitude)
	{
	Latitude = latitude;
	Longitude = longitude;
	Altitude = altitude;
	Timestamp = DateTimeOffset.UtcNow;
	}

maui/src/Essentials/src/Types/Location.shared.cs

Lines 93 to 99 in 9b99433

	public Location(Location point)
	{
	if (point == null)
	throw new ArgumentNullException(nameof(point));
	Latitude = point.Latitude;
	Longitude = point.Longitude;

[janusw]

This is the relevant code:

... and it was modified in this (huge) commit: 4f3075b (by @rmarinho et al.)

[ghost]

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.