Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] Enable FlyoutHeaderWithZeroMarginShouldHaveNoY #20296

Closed
rmarinho opened this issue Feb 1, 2024 · 1 comment
Closed

[testing] Enable FlyoutHeaderWithZeroMarginShouldHaveNoY #20296

rmarinho opened this issue Feb 1, 2024 · 1 comment
Assignees
@jsuarezruiz
Labels
area-testing Unit tests, device tests fixed-in-8.0.7 fixed-in-8.0.10 fixed-in-8.0.14 fixed-in-8.0.40 platform/iOS 🍎 t/bug Something isn't working testing-flakiness testing-reenable
Milestone
.NET 8 SR2

Comments

@rmarinho
Copy link
Member

rmarinho commented Feb 1, 2024

Description

the Test FlyoutHeaderWithZeroMarginShouldHaveNoY is failing sometimes on iOS 16.4 and always on iOS 17.0 we need to investigate and enable it back

The test was disable here for adding iOS17 support

Steps to Reproduce

No response

Link to public reproduction project repository

No response

Version with bug

Unknown/Other

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response
@rmarinho rmarinho added t/bug Something isn't working area-testing Unit tests, device tests testing-flakiness testing-reenable labels Feb 1, 2024
@rmarinho rmarinho added this to the .NET 8 SR3 milestone Feb 1, 2024
@PureWeen PureWeen mentioned this issue Feb 6, 2024
Merged
@jsuarezruiz jsuarezruiz self-assigned this Feb 8, 2024
@jsuarezruiz
Copy link
Contributor

Is already enabled again https://github.com/dotnet/maui/blob/main/src/Compatibility/ControlGallery/src/Issues.Shared/HeaderFooterShellFlyout.cs#L187

@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2024
@samhouts samhouts modified the milestones: .NET 8 SR3, .NET 8 SR2 Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
area-testing Unit tests, device tests fixed-in-8.0.7 fixed-in-8.0.10 fixed-in-8.0.14 fixed-in-8.0.40 platform/iOS 🍎 t/bug Something isn't working testing-flakiness testing-reenable
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 8 SR2
Development

No branches or pull requests
3 participants
@rmarinho @jsuarezruiz @samhouts