Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore SafeArea on templates and shell flyout item templates #20403

Merged
merged 2 commits into from Feb 7, 2024
Merged

Ignore SafeArea on templates and shell flyout item templates #20403

merged 2 commits into from Feb 7, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Feb 6, 2024

Description of Change

  • The layout for this test needs to have IgnoreSafeArea set to true so that it correctly shifts all the way up to the top of the device
  • We need to ignore the safe area for the template used on flyout items, so when the flyout item gets shifted up into the danger zone it doesn't offset the layout being used for the FlyoutItem itself

Issues Fixed

Fixes #20296

@PureWeen PureWeen requested a review from a team as a code owner February 6, 2024 23:42
@PureWeen PureWeen requested review from mattleibow and rmarinho and removed request for a team February 6, 2024 23:42
mattleibow
mattleibow approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we should add a test for moth cases where the nested layout is ignoring or not ignoring the safe areas.

@PureWeen
Copy link
Member Author

PureWeen commented Feb 7, 2024

Compatibility failures on unrelated

@PureWeen PureWeen merged commit f6d4b94 into release/8.0.1xx-sr2 Feb 7, 2024
6 of 12 checks passed
@PureWeen PureWeen deleted the fix_flyout_header_margin_zero_test branch February 7, 2024 14:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@rmarinho rmarinho rmarinho approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PureWeen @mattleibow @rmarinho @jsuarezruiz