Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate a throwhelper into Maui.Essentials #22602

Closed
Mrnikbobjeff opened this issue May 23, 2024 · 0 comments
Closed

Incorporate a throwhelper into Maui.Essentials #22602

Mrnikbobjeff opened this issue May 23, 2024 · 0 comments

Comments

@Mrnikbobjeff
Copy link
Contributor

Description

This is a duplicate for a Xamarin Essentials ticket which was favored by @mattleibow in here.
The reasoning stays the same, the JIT compiler recognizes these throw helpers and never inlines them. The calling method may thus have a more favourable structure due to not having the execption creation instructions. This might allow further optimizations which previously were not available.
The Essentials Barmometer class for example mirrors this behaviour.

Public API Changes

None, if the attribute is introduced to hide the throw helpers from stack traces

Intended Use-Case

Minor improvement mirroring best practices for library code

@dotnet dotnet locked and limited conversation to collaborators May 23, 2024
@PureWeen PureWeen converted this issue into discussion #22614 May 23, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

1 participant