[Enhancement] Use throwhelper in argument validation scenarios to be more inline friendly and reduce code size and improve generation

[Mrnikbobjeff]

Summary

Throw expressions are relatively expensive size wise, and may be the reason the method is not inlined. For such cases we might consider adding a throwhelper as we currently use for the netstandard notsupported messages.

API Changes

None, everything is internal. We would simply add a level of indirection to the throwhelper which will never be inlined and thus reduce the overall binary size

Intended Use Case

See the SR class in the dotnet/runtime repository, containing messages used to pass to a throwhelper. For a sample application see Barometer.shared.cs where both of the exceptions could be contained in a throwhelper

[mattleibow]

I like this.

[Mrnikbobjeff]

https://gist.github.com/Mrnikbobjeff/3c7e65c8d80cea5ba110fbf4439b40cf shows the improved generation for where we simply want to add the indirection. Simply not having to build an exception frame should also be an improvement

[Mrnikbobjeff]

The inlining would actually not happen regardless in barometer because of the exception handling mechanism. Other cases such as sms would profit. The question is how far we would want to take this, as they actuall dont pass string parameters to the throwhelper to reduct code size in the methods even more and have the loading il in the throwhelper.