Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapper for IsSwipePagingEnabledProperty on Android #23129

Closed

Conversation

maonaoda
Copy link
Contributor

Description of Change

Add the mapper for IsSwipePagingEnabledProperty on Android

Issues Fixed

Fixes #23128

@maonaoda maonaoda requested a review from a team as a code owner June 19, 2024 07:19
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jun 19, 2024
@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Redth
Copy link
Member

Redth commented Jun 21, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Redth
Redth previously approved these changes Jun 21, 2024
@@ -68,6 +68,7 @@ override Microsoft.Maui.Controls.Handlers.Compatibility.TableViewModelRenderer.G
override Microsoft.Maui.Controls.Handlers.Compatibility.TableViewRenderer.OnMeasure(int widthMeasureSpec, int heightMeasureSpec) -> void
override Microsoft.Maui.Controls.Handlers.Items.MauiCarouselRecyclerView.OnAttachedToWindow() -> void
override Microsoft.Maui.Controls.Handlers.Items.MauiCarouselRecyclerView.OnDetachedFromWindow() -> void
static Microsoft.Maui.Controls.TabbedPage.MapUpdateOffscreenPageLimit(Microsoft.Maui.Handlers.ITabbedViewHandler! handler, Microsoft.Maui.Controls.TabbedPage! view) -> void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this one now, which should fix the compile errors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PureWeen I had deleted this code. thanks

@maonaoda
Copy link
Contributor Author

maonaoda commented Jul 29, 2024

@PureWeen
@Redth
@jsuarezruiz
anyone alse can help to review this pr that is very useful for me to migrating Xamarin.Forms

@maonaoda maonaoda closed this Aug 6, 2024
@maonaoda maonaoda deleted the feature/enable-IsSwipePagingEnabled branch August 6, 2024 01:46
@maonaoda maonaoda restored the feature/enable-IsSwipePagingEnabled branch August 20, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-tabbedpage TabbedPage community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] OffscreenPageLimitProperty was not working On TabbedViewHandler
3 participants