OnPlatform could be simplified at build time #4716
Assignees
Labels
area-xaml
XAML, CSS, Triggers, Behaviors
fixed-in-6.0.300-rc.1
Look for this fix in 6.0.300-rc.1!
proposal/open
t/perf
The issue affects performance (runtime speed, memory usage, startup time, etc.)
Projects
Comments
StephaneDelcroix
added a commit
that referenced
this issue
Feb 22, 2022
When the platform is known at compile time, and it's known by default as we are multitargetting, replace OnPlatfomExtension by the actual value. This is done early in the parsing so every other optimization is unaffected. From a perf point of view, there are multiple gains: - OnPlatformExtension is executed at runtime, and makes use of reflection. Removing OnPlatformExtensions from the tree reduces this to nothing. - Values in OnPlatformExtension never benefitted from compiledtypeconverters - not generating the IL for the OnPlatform is huge win too. The unitest goes from 189 instructions to 42. fixes #4716
18 tasks
StephaneDelcroix
added a commit
that referenced
this issue
Mar 10, 2022
When the platform is known at compile time, and it's known by default as we are multitargetting, replace OnPlatfomExtension by the actual value. This is done early in the parsing so every other optimization is unaffected. From a perf point of view, there are multiple gains: - OnPlatformExtension is executed at runtime, and makes use of reflection. Removing OnPlatformExtensions from the tree reduces this to nothing. - Values in OnPlatformExtension never benefitted from compiledtypeconverters - not generating the IL for the OnPlatform is huge win too. The unitest goes from 189 instructions to 42. fixes #4716
ghost
locked as resolved and limited conversation to collaborators
Eilon
added
t/perf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
For XamlC scenarios (Release builds), as we now multi-targeting, {OnPlatform} markup extensions could be simplified at build time.
this Xaml code
should be evaluated as
on iOS, and
Padding="30"on other platforms.This is possible as the platform won't change while the app is build.
To avoid writing too much specialised code around this, I'd recommend adding this rule as a visitor early in the parsing, before the IL generation, so the IL generator (XamlC) won't see any difference.
/cc @eerhardt
Public API Changes
/
Intended Use-Case
/
The text was updated successfully, but these errors were encountered: