Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell.NavBarIsVisible does not update on hot reload on Android 8 #7459

Closed
NoThrottle opened this issue May 25, 2022 · 2 comments · Fixed by #17358
Closed

Shell.NavBarIsVisible does not update on hot reload on Android 8 #7459

NoThrottle opened this issue May 25, 2022 · 2 comments · Fixed by #17358
Assignees
@spadapet
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! p/2 Work that is important, but is currently not scheduled for release partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone
.NET 8 GA

Comments

@NoThrottle
Copy link

NoThrottle commented May 25, 2022 •
edited
Loading

Description

Shall.NavBarIsVisible is a property that tells the ShellContent whether it should display the Navigation Bar. When you change this between true or false, the change is not immediately reflected. You can modify the Title property from "Home" to anything (e.g "homeawd") and the title will update, but any changes to the navbarisvisible property will still not be reflected.

For the changes to be reflected, you need to press restart in visual studio (as opposed to hot reload).

I have not tested this in other versions of android, or on other platforms.

Steps to Reproduce

  1. Create a New Project > .NET MAUI App
  2. Go to Solution Explorer and open AppShell.xaml
  3. Run an Android 8 emulator or connect an Android 8 running device.
  4. Run the app on said devices.
  5. Add Shell.NavBarIsVisible="False" under ShellContent
  6. Save

Nothing should happen to the app

  1. Change the Title property from "Home" to anything like "Hello".

It should update and you will see it since the navbar is still visible.

  1. Restart the app (Ctrl+Shift+F5 is the default)

Once it's done, you should see the changes to the NavBar be reflected.

Version with bug

Release Candidate 3 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Android 8 (API 26)

Did you find any workaround?

I just do a full restart instead of a hot reload to see the changes.

Relevant log output

No response
@NoThrottle NoThrottle added s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working labels May 25, 2022
@NoThrottle NoThrottle changed the title Shell.NavBarIsVisible does not update on hot reload Shell.NavBarIsVisible does not update on hot reload on Android 8 May 25, 2022
@kristinx0211 kristinx0211 added s/verified Verified / Reproducible Issue ready for Engineering Triage and removed s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels May 25, 2022
@kristinx0211
Copy link

verified repro on android 12 with 17.3.0 Preview 2.0 [32524.359.main].

@jsuarezruiz jsuarezruiz added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label May 25, 2022
@samhouts samhouts removed the s/verified Verified / Reproducible Issue ready for Engineering Triage label Apr 5, 2023
@samhouts samhouts added partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging labels Jul 14, 2023
@spadapet spadapet added the p/2 Work that is important, but is currently not scheduled for release label Jul 21, 2023
@spadapet spadapet self-assigned this Aug 10, 2023
@Zhanglirong-Winnie Zhanglirong-Winnie added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Sep 13, 2023
@Zhanglirong-Winnie
Copy link
Collaborator

Verified this issue with Visual Studio Enterprise 17.8.0 Preview 1.0. Can repro on android platform.
5

@spadapet spadapet mentioned this issue Sep 13, 2023
Merged
@samhouts samhouts added this to the Under Consideration milestone Sep 13, 2023
@spadapet spadapet mentioned this issue Sep 21, 2023
Open
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Oct 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@spadapet spadapet

Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! p/2 Work that is important, but is currently not scheduled for release partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Milestone
.NET 8 GA
6 participants
@spadapet @jsuarezruiz @samhouts @NoThrottle @Zhanglirong-Winnie @kristinx0211