Changing value of Shell.NavBarIsVisible should change visibility of toolbar (ShellToolbar) #17358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadapet
added
the
partner/hot-reload-xaml
PureWeen
reviewed
Sep 13, 2023
|
Ping @PureWeen for review |
PureWeen
approved these changes
Sep 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This change updates the visibility of the ShellToolbar as the value of Shell.NavBarIsVisible changes (either through XAML Hot Reload or through code).
For apps that use
Shell: TheShell.NavBarIsVisibleattached property can be set on any element from the rootShelldown to the currentPage. The value ofShell.NavBarIsVisibleneeds to act like its inherited down to thePage.The old code would copy the value of
Shell.NavBarIsVisibledown through the element tree. Once it's copied, that's it, it won't be updated by inheritance again. I'm removing that inheritance copy, and instead have theShellToolbarlook for the value ofShell.NavBarIsVisibleat the currentPage, and go up through parents to theShell.ShellToolbaralready listened for thePropertyChangedevent on theShell, so that event is being used to notify when any element has a change forShell.NavBarIsVisible.Issues Fixed
Fixes #7459 (Shell.NavBarIsVisible does not update on hot reload)