Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Maui.Graphics into the main .NET MAUI repository #7901

Closed
7 of 16 tasks
hartez opened this issue Jun 9, 2022 · 8 comments · Fixed by #8739
Closed
7 of 16 tasks

Move Maui.Graphics into the main .NET MAUI repository #7901

hartez opened this issue Jun 9, 2022 · 8 comments · Fixed by #8739
Assignees
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing
Milestone

Comments

@hartez
Copy link
Contributor

hartez commented Jun 9, 2022

To make issue tracking, maintenance, and integration easier, we will move Maui.Graphics from it's current home (https://github.com/dotnet/Microsoft.Maui.Graphics) into this repository.

Maui.Graphics will continue to be built/distributed as a separate NuGet package, and will retain it's own solution and build process; using and contributing to Maui.Graphics won't change. We will continue to ship updates to Maui.Graphics independently from .NET MAUI.

Rationale

Because .NET MAUI depends on Maui.Graphics so heavily, a lot of users aren't clear on where to report graphics-related issues with .NET MAUI. And because the graphics issues are in another repo, the .NET MAUI team is spending a lot of maintenance effort watching two repos, making sure issues are in the correct repo, de-duplicating issues between the repos, making sure fixed issues are closed, etc. By putting this all in one place, we can reduce the overhead and confusion.

Issues

Part of this task will be transferring all of the open issues from Maui.Graphics to this repository.

Projects Merged

@hartez hartez added this to the 6.0-sr2 milestone Jun 9, 2022
@adegeo
Copy link

adegeo commented Jun 9, 2022

Man, I just was sitting here hunting around for 20 minutes trying to find the classes and types and where the code was. Funny thing is that the source peek in Visual Studio didn't give me the header text telling me the Color type is in a different DLL so I was really hunting around the main source for the type. I was using powershell select-string trying to find the code etc. Finally I realized it was in a different repo...

So happy to see this happen!

@Eilon Eilon added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label Jun 9, 2022
@Eilon
Copy link
Member

Eilon commented Jun 9, 2022

Part of this task will be transferring all of the open issues from Maui.Graphics to this repository.

There is no REST API for this, but it appears that the GitHub CLI can do transfers: https://cli.github.com/manual/gh_issue_transfer. Or, if you're into GraphQL, there is a GraphQL mutation API for it https://docs.github.com/en/graphql/reference/mutations#transferissue

After moving the code and open issues, please add a note to the README saying where to find the code/issues, and then Archive the repo, which is what we've done to other repos that had their code moved to somewhere else. Example:

@manishbisen
Copy link

This will be awesome .

@Eilon
Copy link
Member

Eilon commented Jun 10, 2022

Of course I forgot to actually put an example. Here's an example archived repo whose code moved: https://github.com/aspnet/RazorTooling

And GitHub shows a nice info bar at the top:

image

And we updated the readme to tell folks where to go:

image

@janseris
Copy link

janseris commented Jun 10, 2022

I hope this will help resolving the Maui.Graphics issues quicker.

From the README.md:

Status

This is an experimental library;

Disclaimer

There is no official support

Is that still true?

@hartez
Copy link
Contributor Author

hartez commented Jun 13, 2022

Is that still true?

That information is out-of-date.

@adegeo
Copy link

adegeo commented Jun 13, 2022

@Eilon I would ping the .NET SDK team, they swapped repos 1 or 2 years ago and had quite a number of open issues to contend with, they may have a tool or something ready to go.

@Eilon
Copy link
Member

Eilon commented Jun 14, 2022

@adegeo I was one of the ones who did this for the AspNetCore repo several years ago, moving thousands of issues 😄 But back that I used Selenium (I think?) to automate the GitHub UI using FireFox because there was no API for moving issues!

These days with the GitHub CLI or GraphQL it should take like 10 minutes to move everything 😄 There aren't even that many issues, so it would take longer to fully automate it than it would to just run the GitHub CLI a few dozen times!

@mattleibow mattleibow linked a pull request Jun 18, 2022 that will close this issue
5 tasks
@mattleibow mattleibow self-assigned this Jun 18, 2022
@hartez hartez modified the milestones: 6.0-sr2, 6.0-sr3 Jun 27, 2022
@mattleibow mattleibow modified the milestones: 6.0-sr3, 6.0-servicing Jul 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing
Projects
None yet
6 participants