Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Fix COMException using Connectivity class #10062

Merged
merged 1 commit into from
Sep 13, 2022
Merged

[Windows] Fix COMException using Connectivity class #10062

merged 1 commit into from
Sep 13, 2022

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix COMException using Connectivity class on Windows.

fix-7393

Issues Fixed

Fixes #9972

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/windows 🪟 area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info labels Sep 12, 2022
@MagicAndre1981 MagicAndre1981 mentioned this pull request Sep 12, 2022
Closed
mattleibow
mattleibow approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unfortunate this. Can we file a bug and see if this is a bug in the WASDK? This should only be accessing system things and not tied to a particular Window.

@rmarinho rmarinho merged commit 6bd3273 into main Sep 13, 2022
@rmarinho rmarinho deleted the fix-9972 branch September 13, 2022 10:15
@mattleibow mattleibow mentioned this pull request Sep 13, 2022
Open
@mattleibow mattleibow mentioned this pull request Oct 14, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees
No one assigned
Labels
area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connectivity implementation not thread-safe on Windows, returning incorrect network status
3 participants
@jsuarezruiz @mattleibow @rmarinho