Compress Grid measurements for star rows/columns #10073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with stars; Update GridLayoutManager to compress measurement for stars; Fixes #7531
Eilon
added
the
area-layout
|
Just checking if this is meant for net6 SR or net7 RC2? main is now RC2. |
It's in the iteration plan for net7. |
PureWeen
approved these changes
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Grid measurements are returning the fully expanded values for star rows/columns when measuring a Grid with Fill alignment, rather than returning the minimum viable measurement values.
These changes modify the Grid measurement to return the smallest value which satisfies the constraints on measure.
Issues Fixed
Fixes #7531