Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure StackLayout Spacing property propagates to generated Grid #10376

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Make sure StackLayout Spacing property propagates to generated Grid #10376

merged 2 commits into from
Sep 28, 2022

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Sep 28, 2022 •
edited

Description of Change

The Spacing property of StackLayout isn't being set appropriately for the generated Grid when using "AndExpand".

These changes make sure it propagates to ColumnSpacing for horizontal layouts and RowSpacing for vertical layouts.

These changes also propagate Margin and Padding.

@hartez hartez marked this pull request as draft September 28, 2022 16:09
@hartez hartez marked this pull request as ready for review September 28, 2022 16:26
@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Sep 28, 2022
@PureWeen PureWeen merged commit 969e7df into main Sep 28, 2022
@PureWeen PureWeen deleted the fix-andexpand-spacing branch September 28, 2022 20:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees
No one assigned
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hartez @mattleibow @Eilon @PureWeen