Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min width/height to template styles of select controls #10425

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

rachelkang
Copy link
Member

Description of Change

A min size of 44x44 is required for the accessibility of interactive controls, particularly on Android.
Therefore, a min width/height was set in template styles for select controls:

  • Button
  • ImageButton
  • CheckBox
  • RadioButton
  • Editor
  • Entry
  • Picker
  • DatePicker
  • TimePicker

Interactive controls not addressed here will be addressed separately (i.e. SearchView #2956, IndicatorView #10404)

Issues Fixed

Fixes #2957

@rachelkang rachelkang added the legacy-area-a11y Relates to accessibility label Sep 30, 2022
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Xamarin.Forms this was managed at the Renderer level, should some controls require a minimum at the Handlers level?

@AmrAlSayed0
Copy link
Contributor

While it's "good" for accessibility to have clickable controls be 44 px or larger, it should stay relatively easy to override that for people who really want to override that behavior. In this case, setting the minimum height/width on the control itself or overriding the global styles would be enough instead of subclassing the handler which much harder for most users

@rmarinho rmarinho merged commit 983485e into main Oct 4, 2022
@rmarinho rmarinho deleted the android_controls_min_size branch October 4, 2022 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
@Eilon Eilon added the t/a11y Relates to accessibility label May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
legacy-area-a11y Relates to accessibility t/a11y Relates to accessibility
Projects
None yet
6 participants