[ci] Include shortened MSIs in multi-target drop #10495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `<MultiTargetPackNames/>` item group is used as filter to determine the VS Drop location that workload MSIs should be uploaded to. Any packs with names that match the items in this group will be uploaded to a "multitarget" drop that can be used across VS versions. Commit e857f74 shortened most of the MSI file names, breaking this filtering system. The filter has been updated to account for the shorter MSI names.
|
@mattleibow this should go to all branches that also got commit e857f74, including net6.0 ones. |
mattleibow
approved these changes
Oct 5, 2022
mattleibow
pushed a commit
that referenced
this pull request
Oct 5, 2022
The `<MultiTargetPackNames/>` item group is used as filter to determine the VS Drop location that workload MSIs should be uploaded to. Any packs with names that match the items in this group will be uploaded to a "multitarget" drop that can be used across VS versions. Commit e857f74 shortened most of the MSI file names, breaking this filtering system. The filter has been updated to account for the shorter MSI names.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<MultiTargetPackNames/>item group is used as filter to determine the VS Drop location that workload MSIs should be uploaded to. Any packs with names that match the items in this group will be uploaded to a "multitarget" drop that can be used across VS versions.Commit e857f74 shortened most of the MSI file names, breaking this filtering system. The filter has been updated to account for the shorter MSI names.