[iOS] Fix crash disposing TabbedPage #10594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
force-pushed
the
fix-10362-alternative
branch
from
0f2d649
to
351ce33
Compare
jsuarezruiz
added
area-controls-tabbedpage
jsuarezruiz
reviewed
Oct 11, 2022
src/Controls/src/Core/Compatibility/Handlers/Android/FrameRenderer.cs
Outdated
Show resolved
Hide resolved
jsuarezruiz
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix issue disposing TabbedPage on iOS. For the compatibility handlers the
Elementis being accessed through a shim. The problem with doing this is that the shim nulls out theelementbefore the dispose call happens. I realize that I could have reversed the calls inside the shim so dispose is called before the element is set to null but it seems really risky to change the ordering of things at this point. So, I instead went down a path of least change. I also applied this concept to a few other compatibility handlers we have.Issues Fixed
Fixes #10362