Fix how PopToRoot propagates to handler #10653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
force-pushed
the
fix_pop_to_root
branch
from
70189c0
to
f3c2369
Compare
PureWeen
force-pushed
the
fix_pop_to_root
branch
from
f3c2369
to
26ee302
Compare
jsuarezruiz
approved these changes
Oct 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Shell on windows currently uses the
xplatnav stack to re-arrange itself once a navigation is requested. In all cases (except PopToRootAsync) the navstack is modified before the call is propagated to the platform. I could have reversed these calls as another way to fix this issue but I'm not confident about the ramifications of doing that. So, for this PR I've just modified the shell handler to handle PopToRootAsync itself.Issues Fixed
Fixes #10524