Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foldable] XML doc additions #10972

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

conceptdev
Copy link
Contributor

Description of Change

The Xamarin.Forms TwoPaneView had API documentation available.

This PR includes those API docs (with improvements) as triple-slash XML comments in the .NET MAUI Foldable namespace.

Issues Fixed

Related to #3960

@conceptdev conceptdev added the area-docs Conceptual docs, API docs, Samples label Oct 27, 2022
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@hartez
Copy link
Contributor

hartez commented Nov 1, 2022

@conceptdev Any reason this is still a draft?

@conceptdev
Copy link
Contributor Author

@hartez only to prevent it accidentally being merged without someone taking a look at it... esp since the guidance suggested I target main branch but wasn't sure if it should be the net7.0 branch. Otherwise it's ready to merge AFAIC.

@conceptdev
Copy link
Contributor Author

Upon checking some other api doc PRs, they seem to target main so I'm changing this from Draft to Ready for review

@conceptdev conceptdev marked this pull request as ready for review November 2, 2022 17:16
@jfversluis jfversluis merged commit a48dabc into dotnet:main Nov 3, 2022
jfversluis pushed a commit that referenced this pull request Nov 3, 2022
hartez pushed a commit that referenced this pull request Nov 3, 2022
Co-authored-by: Craig Dunn <craig.dunn@microsoft.com>
@conceptdev conceptdev deleted the conceptdev/foldable-api-docs branch November 3, 2022 22:57
@dotnet dotnet deleted a comment from github-actions bot Nov 18, 2022
@dotnet dotnet deleted a comment from github-actions bot Nov 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-docs Conceptual docs, API docs, Samples t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants