Fix gestures in Label Spans #12027

jsuarezruiz · 2022-12-12T12:57:35Z

Description of Change

Fix gestures in Label Spans.

Android

iOS/Catalyst

Windows
(Work in progress)

To test/validate the changes, open the .NET MAUI Gallery and navigate to the Label page. Tap the Span with the text "Click Me". If the Span changes the TextColor, is working as expected.

Issues Fixed

Fixes #4734
Fixes #8004

jsuarezruiz · 2022-12-14T15:40:05Z

src/Controls/src/Core/Platform/Windows/Extensions/FormattedStringExtensions.cs

+				var span = element.FormattedText.Spans[i];
+
+				var inline = control.Inlines.ElementAt(i);
+				var startRect = inline.ContentStart.GetCharacterRect(LogicalDirection.Forward);


Always returning an empty Rect. Reviewing why is happening and possible workarounds.

IeuanWalker · 2022-12-19T16:07:21Z

@jsuarezruiz not sure if you have or havnt, but could you add a test for multiple clickable spans.

There was an issue in XF where if you had multiple spans with tap gestures, if you clicked on the last span, all the previous spans tap gestures would also trigger.

It was fixed, just want to make sure it doesnt crop back up in MAUI - xamarin/Xamarin.Forms#11650

jsuarezruiz · 2022-12-20T15:53:55Z

@jsuarezruiz not sure if you have or havnt, but could you add a test for multiple clickable spans.

There was an issue in XF where if you had multiple spans with tap gestures, if you clicked on the last span, all the previous spans tap gestures would also trigger.

It was fixed, just want to make sure it doesnt crop back up in MAUI - xamarin/Xamarin.Forms#11650

Good point, I've checked it.

IeuanWalker · 2022-12-30T23:51:11Z

@pictos also wondering if tap gestures will be updated in maui to support keyboard accessibility?

In XF navigating with a keyboard, tap gestured controls were skipped over.

pictos · 2022-12-31T05:06:37Z

@pictos also wondering if tap gestures will be updated in maui to support keyboard accessibility?

In XF navigating with a keyboard, tap gestured controls were skipped over.

@PureWeen , I belive you have more context to answer this question

SadamSkula · 2023-01-23T13:29:28Z

Hi @jsuarezruiz thank you for hard work on implementing this one, as well as other things on MAUI.
Do we have ETA for having this in production?

Best regards,
Sadam

hartez · 2023-02-06T20:28:02Z

Pulling this out of draft, need someone to diagnose the failures from the Android API 23 tests.

src/Controls/samples/Controls.Sample/Pages/Controls/LabelPage.xaml.cs

src/Controls/src/Core/HandlerImpl/Label/Label.Windows.cs

src/Controls/src/Core/Platform/iOS/Extensions/FormattedStringExtensions.cs

src/Core/tests/DeviceTests.Shared/Stubs/ContextStub.cs

# Conflicts: # src/Controls/samples/Controls.Sample/Pages/Controls/LabelPage.xaml.cs # src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt

src/Core/tests/DeviceTests.Shared/Stubs/ContextStub.cs

Changes made. Please re-review.

rmarinho · 2023-02-28T12:34:55Z

src/Controls/src/Core/Platform/GestureManager/GesturePlatformManager.Android.cs

 			if (platformView == null)
 				return;

-			if (View.GestureRecognizers.Count == 0)
+			if (View.GestureController.CompositeGestureRecognizers.Count == 0)


Why this change?

rmarinho · 2023-02-28T12:35:58Z

src/Controls/src/Core/HandlerImpl/Label/Label.Windows.cs

+			{
+				if (Handler is LabelHandler labelHandler && labelHandler.PlatformView is TextBlock textBlock)
+				{
+					_textBlock = textBlock;


Why do we need the native view change here? can't we look at size changes on the Label itself ? Override Measure or something ?

src/Controls/src/Core/Platform/Windows/Extensions/FormattedStringExtensions.cs

…xaml.cs Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

github-actions · 2023-03-03T11:59:23Z

Thank you for your pull request. We are auto-formating your source code to follow our code guidelines.

mandel-macaque

Some comments need to still be addressed and we have some NRE cases in the code.

src/Controls/src/Core/HandlerImpl/Label/Label.Windows.cs

mandel-macaque · 2023-03-10T00:01:02Z

src/Controls/src/Core/HandlerImpl/Label/Label.Windows.cs

+					var heights = new List<double>();
+					for (var i = 0; i < formatted.Spans.Count; i++)
+					{
+						var span = formatted.Spans[i];


@jsuarezruiz ?

src/Controls/src/Core/Platform/Windows/Extensions/FormattedStringExtensions.cs

src/Controls/src/Core/HandlerImpl/Label/Label.Windows.cs

mandel-macaque · 2023-03-14T19:00:16Z

src/Controls/src/Core/HandlerImpl/Label/Label.Windows.cs

+					var heights = new List<double>();
+					for (var i = 0; i < formatted.Spans.Count; i++)
+					{
+						var span = formatted.Spans[i];


Still stands.

hartez

The targets seem a bit off on iOS.

Testing this on iOS, I can tap above and below the "Click Me" Label and it changes the colors - for example, I can tap the "Colors" Label above "Click Me" and the event fires.

Same thing with the part that says "Two clickable spans in one line" - I can tap the word "line" and it causes the color change.

jsuarezruiz · 2023-04-05T12:52:27Z

This PR affects all platforms, and has quite a few changes here and there. To facilitate its review and have fixes in releases as soon as possible, I am going to close this PR to open smaller PRs focused on each platform.

jsuarezruiz added 4 commits December 12, 2022 12:43

Changes in the sample

d07084f

Fix on Android

235f2f7

Fix Span gestures on iOS and Catalyst

72261ac

Updated sample

ad72d29

jsuarezruiz added t/bug Something isn't working area-controls-label Label, Span area-gestures Gesture types labels Dec 12, 2022

ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Dec 12, 2022

Recalculate Spans positions on Windows

d8d2231

jsuarezruiz commented Dec 14, 2022

View reviewed changes

jsuarezruiz added 2 commits December 14, 2022 17:11

Fixed broken tests

d3492fe

Merge branch 'main' into fix-4734

186ece6

jsuarezruiz added 2 commits December 20, 2022 16:35

Changes calculating spans position

e6a09ee

Added more samples

ba6a703

Merge branch 'main' into fix-4734

702217a

angelru mentioned this pull request Jan 17, 2023

Gestures don't work on Label Spans #4734

Closed

4 tasks

Merge branch 'main' into fix-4734

de574ea

Merge branch 'main' into fix-4734

7d60852

AmSmart mentioned this pull request Feb 3, 2023

CollectionView does not allow clicking of child elements #10209

Closed

hartez marked this pull request as ready for review February 6, 2023 20:27

mandel-macaque requested changes Feb 7, 2023

View reviewed changes

Merge branch 'main' into fix-4734

3934488

# Conflicts: # src/Controls/samples/Controls.Sample/Pages/Controls/LabelPage.xaml.cs # src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt

PureWeen previously requested changes Feb 7, 2023

View reviewed changes

src/Core/tests/DeviceTests.Shared/Stubs/ContextStub.cs Outdated Show resolved Hide resolved

Changes based on PR feedback

07222d0

samhouts requested review from hartez, mandel-macaque and PureWeen February 27, 2023 17:32

rmarinho reviewed Feb 28, 2023

View reviewed changes

src/Controls/src/Core/Platform/Windows/Extensions/FormattedStringExtensions.cs Outdated Show resolved Hide resolved

jsuarezruiz and others added 4 commits March 2, 2023 15:15

Merge branch 'main' into fix-4734

aab794c

Fix issue with device tests

a27d0e3

Update src/Controls/samples/Controls.Sample/Pages/Controls/LabelPage.…

f6e9415

…xaml.cs Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

Auto-format source code

8dc5520

jsuarezruiz added 2 commits March 3, 2023 13:06

Changes based on PR feedback

b467171

Merge branch 'main' into fix-4734

da3e117

mandel-macaque requested changes Mar 10, 2023

View reviewed changes

jsuarezruiz added 2 commits March 13, 2023 13:52

Merge branch 'main' into fix-4734

b71220a

Merge branch 'main' into fix-4734

151a569

mandel-macaque requested changes Mar 14, 2023

View reviewed changes

hartez suggested changes Mar 17, 2023

View reviewed changes

jsuarezruiz added 5 commits March 20, 2023 14:19

Merge branch 'main' into fix-4734

32f80ba

Protect from possible NRE

b0f1ed6

Refactor code

87c7cfb

Merge branch 'main' into fix-4734

a3fc72e

Merge branch 'main' into fix-4734

615cac4

jsuarezruiz mentioned this pull request Mar 29, 2023

Move to the backlog - Transparency - community needs fixes to move to maui. #14255

Closed

jsuarezruiz closed this Apr 5, 2023

github-actions bot locked and limited conversation to collaborators Dec 13, 2023

Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix gestures in Label Spans #12027

Fix gestures in Label Spans #12027

jsuarezruiz commented Dec 12, 2022 •

edited

Loading

jsuarezruiz Dec 14, 2022

IeuanWalker commented Dec 19, 2022

jsuarezruiz commented Dec 20, 2022

IeuanWalker commented Dec 30, 2022

pictos commented Dec 31, 2022

SadamSkula commented Jan 23, 2023

hartez commented Feb 6, 2023

rmarinho Feb 28, 2023

rmarinho Feb 28, 2023

github-actions bot commented Mar 3, 2023

mandel-macaque left a comment

mandel-macaque Mar 10, 2023

mandel-macaque Mar 14, 2023

hartez left a comment

jsuarezruiz commented Apr 5, 2023

Fix gestures in Label Spans #12027

Fix gestures in Label Spans #12027

Conversation

jsuarezruiz commented Dec 12, 2022 • edited Loading

Description of Change

Issues Fixed

jsuarezruiz Dec 14, 2022

Choose a reason for hiding this comment

IeuanWalker commented Dec 19, 2022

jsuarezruiz commented Dec 20, 2022

IeuanWalker commented Dec 30, 2022

pictos commented Dec 31, 2022

SadamSkula commented Jan 23, 2023

hartez commented Feb 6, 2023

rmarinho Feb 28, 2023

Choose a reason for hiding this comment

rmarinho Feb 28, 2023

Choose a reason for hiding this comment

github-actions bot commented Mar 3, 2023

mandel-macaque left a comment

Choose a reason for hiding this comment

mandel-macaque Mar 10, 2023

Choose a reason for hiding this comment

mandel-macaque Mar 14, 2023

Choose a reason for hiding this comment

hartez left a comment

Choose a reason for hiding this comment

jsuarezruiz commented Apr 5, 2023

jsuarezruiz commented Dec 12, 2022 •

edited

Loading