[Housekeeping] Alternative to #11795 #12134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
jsuarezruiz
changed the title
|
@PureWeen Thoughts? |
PureWeen
requested changes
Jan 25, 2023
There was a problem hiding this comment.
@PureWeen Thoughts?
Would it be possible to add tests? I have some modal tests here.
https://github.com/dotnet/maui/tree/main/src/Controls/tests/DeviceTests/Elements/Modal
I'm thinking you can push the page then grab the VC to see the presentation style?
mandel-macaque
approved these changes
Feb 15, 2023
PureWeen
requested changes
Feb 15, 2023
src/Controls/tests/DeviceTests/Elements/Modal/ModalTests.iOS.cs
Outdated
Show resolved
Hide resolved
PureWeen
requested changes
Feb 17, 2023
PureWeen
requested changes
Feb 23, 2023
|
/azp run |
PureWeen
approved these changes
Mar 8, 2023
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Allow transparent modal pages. Alternative to #11795
Issues Fixed
Fixes #12031