Set Icon to null and back again, working around Android issue #13267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be an Android bug where it sometimes doesn't compute the updated icon position correctly, treating IconGravityTextEnd as if it were IconGravityTextStart. Setting the Icon to null and then back again forces the resetIconDrawable call here https://github.com/material-components/material-components-android/blob/25b3c2b15c9b9499993d6d4a5fb491ffce04517a/lib/java/com/google/android/material/button/MaterialButton.java#L852-L869 to happen which seems to make things work properly. Fixes #11755
Redth
approved these changes
Feb 14, 2023
|
Looks reasonable to me. Is this ready for review? Are you planning on trying to add some tests? |
ghost
added
the
area/controls 🎮
|
I went back to this and finally got a working device test. |
PureWeen
requested changes
May 14, 2023
src/Controls/tests/DeviceTests/Elements/Layout/LayoutTests.Android.cs
Outdated
Show resolved
Hide resolved
PureWeen
reviewed
May 14, 2023
| using Microsoft.Maui.Platform; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.Maui.DeviceTests | ||
| { | ||
| public partial class LayoutTests | ||
| { | ||
| [Fact, Category(TestCategory.Layout)] | ||
| public async Task NestedButtonHasExpectedIconPosition() |
There was a problem hiding this comment.
Can we update this test so that it takes in all four variations of Button.ButtonContentLayout.ImagePosition and then those all get validated as being in the correct place?
There was a problem hiding this comment.
Good idea. Updated. That caught a failure with Top as well - a failure which I oddly wasn't able to reproduce in the sandbox test app, but nevertheless it looks to be a legit failure, fixed by updating the Top logic similarly in ButtonExtensions, which I did.
PureWeen
approved these changes
May 14, 2023
rmarinho
pushed a commit
that referenced
this pull request
May 30, 2023
* Set Icon to null and back again, working around Android issue There seems to be an Android bug where it sometimes doesn't compute the updated icon position correctly, treating IconGravityTextEnd as if it were IconGravityTextStart. Setting the Icon to null and then back again forces the resetIconDrawable call here https://github.com/material-components/material-components-android/blob/25b3c2b15c9b9499993d6d4a5fb491ffce04517a/lib/java/com/google/android/material/button/MaterialButton.java#L852-L869 to happen which seems to make things work properly. Fixes #11755 * Add device test * Update test so results show in window * Update to use AttachAndRun, for performance * Use new base class method to call AttachAndRun * Remove unneeded InvokeOnMainThreadAsync * Update to use CreateHandlerAndAddToWindow * Use Theory to test all 4 icon positions * Update the logic for Top as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There seems to be an Android bug where it sometimes doesn't compute the updated icon position correctly, treating IconGravityTextEnd as if it were IconGravityTextStart. Setting the Icon to null and then back again forces the resetIconDrawable call here
https://github.com/material-components/material-components-android/blob/25b3c2b15c9b9499993d6d4a5fb491ffce04517a/lib/java/com/google/android/material/button/MaterialButton.java#L852-L869 to happen which seems to make things work properly.
Thanks go to @PureWeen who helped a lot with this fix. We tried several variations before settling on this.
Issues Fixed
Fixes #11755