[net7.0] Fix Modal page offset measuring for AdjustPan and AdjustResize #13401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
force-pushed
the
backport/pr-12661-to-net7.0
branch
from
fe07490
to
1963719
Compare
PureWeen
commented
Feb 16, 2023
|
|
||
| namespace Microsoft.Maui.Controls.Platform | ||
| { | ||
| internal class GenericGlobalLayoutListenerImproved : Object, ViewTreeObserver.IOnGlobalLayoutListener |
There was a problem hiding this comment.
For the backport I added this class to minimize the amount of code being changed.
For .NET8 I've just modified GenericGlobalLayoutListener and updated everywhere that uses that code.
hartez
approved these changes
Feb 16, 2023
|
@hartez So happy this bug is fixed - and can't wait to get it running in our app. Do you know when the next service release is? Asking because we are supposed to release our .net maui app EOB next friday, and this is one of the last release blockers. Kind regards Emil Lind |
|
@noque-lind you can try the nuget I have here https://www.nuget.org/packages/PureWeen.Maui.FixesAndWorkarounds If that still doesn't fix your modals then please log a bug here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12661 to net7.0
/cc @PureWeen