[iOS] Don't scroll more than the available scrollable space #13415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandel-macaque
approved these changes
Feb 17, 2023
hartez
reviewed
Feb 17, 2023
hartez
approved these changes
Feb 17, 2023
Eilon
added
the
area-layout
dustin-wojciechowski
approved these changes
Feb 21, 2023
hartez
approved these changes
Feb 23, 2023
Eilon
removed
the
area-layout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On iOS if you were trying to scroll more than the available scroll space it would still put the ContentOffset of the UIScrollView to the requested value. That would cause the content to sometimes disappear, it also didn't show the same UI as for example on Android.
With this change we clamp the value to the available scroll height/width.
Fixes #7373