Include border size in Frame's measurement #13419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-layout
mandel-macaque
approved these changes
Feb 21, 2023
Android renders seemingly fine because it clips the inner content instead of the border, but to be consistent with the other platforms, the border should take up space too in the measurement.
Similarly, iOS was working fine but not taking into account the border thickness as part of the content measuring, this makes it consistently doing so now.
Redth
changed the title
hartez
approved these changes
Feb 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Frame on windows may have its border clipped in some cases. I believe this is due to the border thickness not being considered in the handler's MeasureOverride. This PR adds the border thickness into the calculation.
UPDATE: iOS and Android need this treatment too. Android was confusingly incorrect since it was clipping the inner content and the border would still appear correctly, but the content was not measuring to account for the border space. iOS also. Updated the PR to address that too.
Issues Fixed
Fixes #9099