move BootstrapHelper to Maui Core #13431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chabiss
added
the
partner/hot-reload-xaml
|
|
Eilon
reviewed
Feb 21, 2023
Eilon
reviewed
Feb 21, 2023
Eilon
approved these changes
Feb 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The BootstrapHelper for hooking the MAUI LVT is inside Microsoft.Maui.Controls.Compatibility. However, Microsoft.Maui.Controls.Compatibility will no longer be referenced by default with future MAUI apps with .NET 8. We need to create another BootstrapHelper into core and having VS tries the BootstrapHelper core first, and then the one in Microsoft.Maui.Controls.Compatibility for older projects.
Issues Fixed
Bug 1749320
Fixes #