Change Windows WebView Cookies to CoreWebView2 #13518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
t/bug
|
@jfversluis you can use httpbin.org to interact with cookies (and other methods) we use this service a lot in xamarin-ios and it has a docker image in case we wanted to spawn a docker container with it in the CI, which will ensure is always around. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Awesome @mandel-macaque! Thank you! Added a sample that looks at httpbin.org for now |
mandel-macaque
requested changes
Mar 6, 2023
mandel-macaque
requested changes
Mar 8, 2023
Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
mandel-macaque
approved these changes
Mar 9, 2023
|
🚨 API change(s) detected @davidbritch FYI |
mattleibow
added
the
backport/suggested
hartez
added
backport/NO
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The Windows implementation of how we handled cookies in
WebViewwas outdated. Updated it to use the more modern API and make it work again.I've added a button to the sample app which sets a cookie for httpbin.org, a site that allows you to read the cookies that are set back to you. Go to Controls > WebView and scroll down to the Load httpbin.org with Cookies button.
Click that and in the loaded website go to Cookies > Get /Cookies > Try it out > Execute and make sure the cookie that was set in code is shown.
Issues Fixed
Fixes #3901