Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled x:ClassModifier attribute to set the visibility of rootType #13531

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

egvijayanand
Copy link
Contributor

Description of Change

As of now, while creating a type in XAML, the visibility is always set to public. But at times, there's a need to make the type hidden so that it's not accessible to the consumers in the scenario of library development. x:ClassModifier is the attribute that controls this behavior in XAML. This is to be defined at the root node.

Web Ref.

Issues Fixed

Fixes #12322

@ghost ghost added the community ✨ Community Contribution label Feb 23, 2023
@ghost
Copy link

ghost commented Feb 23, 2023

Hey there @egvijayanand! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Eilon Eilon added the area-xaml XAML, CSS, Triggers, Behaviors label Feb 23, 2023
@jfversluis
Copy link
Member

/azp run

@jfversluis
Copy link
Member

@StephaneDelcroix ?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jfversluis jfversluis merged commit 33240ea into dotnet:main Feb 24, 2023
@ghost
Copy link

ghost commented Feb 24, 2023

🚨 Breaking change detected @davidbritch FYI

@jfversluis
Copy link
Member

Not so much breaking, more a new API!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-xaml XAML, CSS, Triggers, Behaviors community ✨ Community Contribution t/breaking 💥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need the option to modify the visibility of the XAML code-behind class so as to hide it from library consumers
5 participants