Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for text not properly aligned with radioButton when in RTL for Android #13610

Merged
merged 7 commits into from
Mar 9, 2023

Conversation

dustin-wojciechowski
Copy link
Contributor

@dustin-wojciechowski dustin-wojciechowski commented Feb 28, 2023

Description of Change

This fixes an issue on Android where Right To Left languages are being displayed as Left To Right.

Before After
image image

Issues Fixed

Fixes #6708

@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Feb 28, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request. We are auto-formating your source code to follow our code guidelines.

@jsuarezruiz jsuarezruiz added the area-controls-radiobutton RadioButton, RadioButtonGroup label Mar 1, 2023
hartez
hartez previously requested changes Mar 7, 2023
src/Core/src/Platform/Android/RadioButtonExtensions.cs Outdated Show resolved Hide resolved
@jfversluis
Copy link
Member

@dustin-wojciechowski just double-checking... Does this also fix: #6939 ?

@mattleibow mattleibow dismissed stale reviews from hartez and mandel-macaque March 9, 2023 10:30

fixed!

@mattleibow mattleibow merged commit 569b057 into main Mar 9, 2023
@mattleibow mattleibow deleted the radiobutton-flowdirection-bug branch March 9, 2023 10:30
@dustin-wojciechowski
Copy link
Contributor Author

@dustin-wojciechowski just double-checking... Does this also fix: #6939 ?

I was a little confused by the repros using LTR text in both of these issues, but yeah this would complete the earlier fix that went in that fixed the text disappearing.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radiobutton doesn't appear correctly when FlowDirection is RightToLeft
7 participants