[Windows] Implement SearchBar CancelButtonColor on Windows #13622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
ghost
added
the
legacy-area-controls
PureWeen
requested changes
Mar 1, 2023
mandel-macaque
requested changes
Mar 1, 2023
PureWeen
previously requested changes
Mar 4, 2023
mandel-macaque
approved these changes
Mar 15, 2023
rachelkang
reviewed
Mar 16, 2023
| var searchBarHandler = CreateHandler(searchBar); | ||
| await searchBarHandler.PlatformView.AttachAndRun(async () => | ||
| { | ||
| await AssertionExtensions.Wait(() => searchBarHandler.PlatformView.FocusState != UI.Xaml.FocusState.Unfocused); |
There was a problem hiding this comment.
hmm... what is the reason for checking this?
There was a problem hiding this comment.
The CancelButton only appears when the SearchBar has text and the focus. For that reason, here, we wait until be sure that the native control is focused.
rachelkang
approved these changes
Mar 16, 2023
rmarinho
approved these changes
Mar 17, 2023
|
@PureWeen Could I get your feedback here?. Thanks! |
rmarinho
approved these changes
Mar 22, 2023
|
@rmarinho You should also remove this line, or at least the reference to this now closed issue: |
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implement SearchBar CancelButtonColor on Windows. Checking new issues and adding label, I've seen that 13507 happens basically because it's not implemented. This PR implement the changes in the CancelButtonColor proprerty.
To validate the changes cacn use the SearchBar sample from the .NET MAUI Gallery or the added tests.
Issues Fixed
Fixes #13507