Fix Android ListView header / footer gone (#12312) #13712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect layout value cause header / footer in ListView on Android gone missing / disappear when scrolling.
ghost
added
the
|
Hey there @ooikengsiang! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
hartez
suggested changes
Mar 13, 2023
src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ListViewRenderer.cs
Outdated
Show resolved
Hide resolved
Fix OnLayout calculation that caused header / footer gone missing.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
hartez
suggested changes
Mar 14, 2023
src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ListViewRenderer.cs
Show resolved
Hide resolved
Add back removed null check
hartez
approved these changes
Mar 16, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jfversluis
added
the
backport/suggested
|
Adding backport/suggested label on this one. Had been requested by a customer. |
|
/backport to net7.0 |
PureWeen
added
the
backport/approved
|
Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/4501869700 |
|
Is this Possibly fixed with surety? I am still having issue with Header and footer being miscalculated at scroll? :( I can provide the required Sample, if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix incorrect layout value cause header / footer in ListView on Android gone missing / disappear when scrolling.
Issues Fixed
Fixes #12312