Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RadioButtonGallery TemplateFromStyle page. #13756

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

dustin-wojciechowski
Copy link
Contributor

Description of Change

Since we changed RadioButton's default control template to use Border instead of Frame, and the sample code has been changed in the official documentation, I changed it as well in our Controls.Sample app and updated the values accordingly.

Issues Fixed

On Android, the "check mark" inner ellipse would not draw when you click anywhere within the frame, but were able to outside the frame. See #6938.

Demo:
templateFromStyleFixVid.webm

@dustin-wojciechowski dustin-wojciechowski marked this pull request as ready for review March 8, 2023 03:50
@dustin-wojciechowski dustin-wojciechowski added the area-controls-radiobutton RadioButton, RadioButtonGroup label Mar 8, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Mar 8, 2023
@jfversluis jfversluis merged commit 8eb5c21 into main Mar 8, 2023
@jfversluis jfversluis deleted the dev/update-radiobutton-template-from-style branch March 8, 2023 13:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-radiobutton RadioButton, RadioButtonGroup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants