Correctly propagate BindingContext to Border StrokeShape #13793
Conversation
jsuarezruiz
added
t/bug
ghost
added
the
legacy-area-controls
|
|
||
| if (strokeShape is VisualElement visualElement) | ||
| { | ||
| SetInheritedBindingContext(visualElement, BindingContext); |
There was a problem hiding this comment.
We were not propagating the BindingContext to the Shape used in the StrokeShape property or detecting changes to invalidate the Shape. These are the main changes.
There was a problem hiding this comment.
Do we need Parent AND SetInheritedBindingContext? Does not setting Parent automatically set the binding context? I am not sure, so just checking... Does the order matter?
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
|
|
||
| if (strokeShape is VisualElement visualElement) | ||
| { | ||
| SetInheritedBindingContext(visualElement, BindingContext); |
There was a problem hiding this comment.
Do we need Parent AND SetInheritedBindingContext? Does not setting Parent automatically set the binding context? I am not sure, so just checking... Does the order matter?
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
|
Added sample to validate #13988 |
| propertyChanging: (bindable, oldvalue, newvalue) => | ||
| { | ||
| if (newvalue is not null) | ||
| (bindable as Border)?.StopNotifyingStrokeShapeChanges(); |
There was a problem hiding this comment.
Should this always fire? If I set a value and then null, this will not unsub.
There was a problem hiding this comment.
If this is wrong, can we add a test for this?
| propertyChanging: (bindable, oldvalue, newvalue) => | ||
| { | ||
| if (newvalue is not null) | ||
| (bindable as Border)?.StopNotifyingStrokeChanges(); |
There was a problem hiding this comment.
Same here, nothing ever unsubs.
| } |
There was a problem hiding this comment.
Can we revert this whitespace change?
Eilon
removed
the
legacy-area-controls
Description of Change
This PR apply changes to correctly propagate the Border BindingContext to the StrokeShape.
Added a new sample in the Gallery where the Border StrokeShape bind the CornerRadius to the Border Width.
And unit test.
Issues Fixed
Fixes #13699
Fixes #13988