Refactor keyboard focus code for .NET 8 #13824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
legacy-area-controls
mandel-macaque
requested changes
Mar 10, 2023
src/Controls/src/Core/HandlerImpl/SearchBar/SearchBar.Android.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/HandlerImpl/VisualElement/VisualElement.cs
Outdated
Show resolved
Hide resolved
rachelkang
force-pushed
the
show-keyboard-on-android-focus-addition
branch
2 times, most recently
from
0caa982
to
7c38a30
Compare
rachelkang
force-pushed
the
show-keyboard-on-android-focus-addition
branch
from
c238bfd
to
e3c896d
Compare
rachelkang
force-pushed
the
show-keyboard-on-android-focus-addition
branch
from
e3c896d
to
cb71a6e
Compare
mandel-macaque
approved these changes
Mar 31, 2023
PureWeen
approved these changes
Mar 31, 2023
PureWeen
requested changes
Mar 31, 2023
src/Core/tests/DeviceTests/Handlers/SearchBar/SearchBarHandlerTests.iOS.cs
Outdated
Show resolved
Hide resolved
PureWeen
approved these changes
Apr 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
WIP - need to fix failing keyboard tests on Core
Follow up on #12890 - refactor with mappers for .NET 8
Issues Fixed
Fixes #5983