Use Background as Fill, if Fill is null in Shapes #14216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
mandel-macaque
approved these changes
Mar 29, 2023
rmarinho
reviewed
Apr 13, 2023
| @@ -13,10 +13,13 @@ protected override MauiShapeView CreatePlatformView() | |||
|
|
|||
| public static void MapBackground(IShapeViewHandler handler, IShapeView shapeView) | |||
| { | |||
| handler.UpdateValue(nameof(IViewHandler.ContainerView)); | |||
| handler.ToPlatform().UpdateBackground(shapeView); | |||
| if (shapeView.Background is not null && shapeView.Fill is not null) | |||
There was a problem hiding this comment.
We want both? don't we want one or other to always update ?
There was a problem hiding this comment.
It can be somewhat confusing. The background will be applied to the View background, in a Shape is the background rectangle. With the changes in the PR we are now using Fill to set the Shape background (not to be confused with the view) and if Fill is null, use the Background to fill the Shape. If Fill and Background are not null, will use Fill for the Shape background and Background for the ShapeView background.
There was a problem hiding this comment.
Can we add a comment here so everyone understand in the future?
There was a problem hiding this comment.
Added comments.
rmarinho
approved these changes
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
To draw Shapes we use
ShapeView. The Background property defines the background color or gradient of the ShapeView (rectangle based on the height and width of the control). Inside the ShapeView a Shape is drawn, for example an Ellipse, where the shape background color is defined with the Fill property. If a shadow is set, it is drawn following the shape between the Shape and the background.But if the Fill property is not set and the Background is set, the background of the View is actually drawn but not the Shape. For this reason, the Shadow is not rendered (it has no shape to follow). Check the behavior of the Shadows using Background example with an Ellipse before the changes.
This PR include changes to use the Background property as Fill, if Fill is null in Shapes. This would avoid confusion both when drawing some Shapes like an Ellipse setting the Background property without Fill, or drawing shadows in the same scenario.
Before
After
Issues Fixed
Fixes #13688